Skip to content

Commit d20965f

Browse files
committed
adding empty string in reasons
1 parent d81c128 commit d20965f

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

internal/store/deployment.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ var (
5454
"DeploymentResumed": {},
5555
"MinimumReplicasAvailable": {},
5656
"MinimumReplicasUnavailable": {},
57+
"": {},
5758
}
5859
)
5960

internal/store/deployment_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ func TestDeploymentStore(t *testing.T) {
201201
Status: v1.DeploymentStatus{
202202
Conditions: []v1.DeploymentCondition{
203203
{Type: v1.DeploymentAvailable, Status: corev1.ConditionFalse, Reason: "ThisReasonIsNotAllowed"},
204+
{Type: v1.DeploymentProgressing, Status: corev1.ConditionTrue},
204205
},
205206
},
206207
Spec: v1.DeploymentSpec{
@@ -220,6 +221,9 @@ func TestDeploymentStore(t *testing.T) {
220221
kube_deployment_status_replicas_ready{deployment="depl3",namespace="ns3"} 0
221222
kube_deployment_status_replicas_unavailable{deployment="depl3",namespace="ns3"} 0
222223
kube_deployment_status_replicas_updated{deployment="depl3",namespace="ns3"} 0
224+
kube_deployment_status_condition{condition="Progressing",deployment="depl3",namespace="ns3",reason="",status="false"} 0
225+
kube_deployment_status_condition{condition="Progressing",deployment="depl3",namespace="ns3",reason="",status="true"} 1
226+
kube_deployment_status_condition{condition="Progressing",deployment="depl3",namespace="ns3",reason="",status="unknown"} 0
223227
`,
224228
},
225229
}

0 commit comments

Comments
 (0)