Skip to content

Commit d9572ac

Browse files
Map exact value provided but update value to match the correct casing
1 parent 2990fd5 commit d9572ac

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

internal/store/job.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package store
1919
import (
2020
"context"
2121
"strconv"
22-
"strings"
2322

2423
basemetrics "k8s.io/component-base/metrics"
2524

@@ -430,5 +429,5 @@ func failureReason(jc *v1batch.JobCondition, reason string) bool {
430429
if jc == nil {
431430
return false
432431
}
433-
return strings.EqualFold(jc.Reason, reason)
432+
return jc.Reason == reason
434433
}

internal/store/job_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ func TestJobStore(t *testing.T) {
210210
kube_job_status_active{job_name="FailedJob1",namespace="ns1"} 0
211211
kube_job_status_completion_time{job_name="FailedJob1",namespace="ns1"} 1.495810807e+09
212212
kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="BackoffLimitExceeded"} 1
213-
kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="DeadLineExceeded"} 0
213+
kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="DeadlineExceeded"} 0
214214
kube_job_status_failed{job_name="FailedJob1",namespace="ns1",reason="Evicted"} 0
215215
kube_job_status_start_time{job_name="FailedJob1",namespace="ns1"} 1.495807207e+09
216216
kube_job_status_succeeded{job_name="FailedJob1",namespace="ns1"} 0

0 commit comments

Comments
 (0)