Skip to content

Commit de58db2

Browse files
bartlettc22rexagod
andauthored
restructure testing logic
Co-authored-by: Pranshu Srivastava <[email protected]>
1 parent 24c2194 commit de58db2

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

internal/store/builder_test.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -238,13 +238,21 @@ func TestWithEnabledResources(t *testing.T) {
238238

239239
// Set the enabled resources.
240240
err := b.WithEnabledResources(test.EnabledResources)
241-
if err != nil && !test.err.expectedResourceError {
242-
t.Log("Did not expect error while setting resources (--resources).")
243-
t.Errorf("Test error for Desc: %s. Got Error: %v", test.Desc, err)
241+
if test.err.expectedResourceError {
242+
if err == nil {
243+
t.Log("Did not expect error while setting resources (--resources).")
244+
t.Fatal("Test error for Desc: %s. Got Error: %v", test.Desc, err)
245+
} else {
246+
return
247+
}
248+
}
249+
if err != nil {
250+
t.Log("...")
251+
t.Fatal("...", test.Desc, err)
244252
}
245253

246254
// Evaluate.
247-
if !slices.Equal(b.enabledResources, test.Wanted) && err == nil {
255+
if !slices.Equal(b.enabledResources, test.Wanted) {
248256
t.Log("Expected enabled resources to be equal.")
249257
t.Errorf("Test error for Desc: %s\n Want: \n%+v\n Got: \n%#+v", test.Desc, test.Wanted, b.enabledResources)
250258
}

0 commit comments

Comments
 (0)