lowercase string and simplify logic

jabdoa2 · mrueg · jabdoa2 · commit e26d68240861 · 2023-01-26T17:56:29.000+01:00
Co-authored-by: Manuel Rüger &lt;manuel@rueg.eu&gt;
diff --git a/pkg/customresourcestate/registry_factory.go b/pkg/customresourcestate/registry_factory.go
@@ -635,10 +635,11 @@ func toFloat64(value interface{}, nilIsZero bool) (float64, error) {
 		}
 		return 0, nil
 	case string:
-		if value.(string) == "True" || value.(string) == "true" || value.(string) == "Yes" || value.(string) == "yes" {
+		normalized := strings.ToLower(value.(string))
+		if normalized == "true" || normalized == "yes" {
 			return 1, nil
 		}
-		if value.(string) == "False" || value.(string) == "false" || value.(string) == "No" || value.(string) == "no" {
+		if normalized == "false" || normalized == "no" {
 			return 0, nil
 		}
 		if t, e := time.Parse(time.RFC3339, value.(string)); e == nil {

Original file line number	Diff line number	Diff line change
`@@ -635,10 +635,11 @@ func toFloat64(value interface{}, nilIsZero bool) (float64, error) {`
`635`	`635`	`}`
`636`	`636`	`return 0, nil`
`637`	`637`	`case string:`
`638`		`- if value.(string) == "True" \|\| value.(string) == "true" \|\| value.(string) == "Yes" \|\| value.(string) == "yes" {`
	`638`	`+ normalized := strings.ToLower(value.(string))`
	`639`	`+ if normalized == "true" \|\| normalized == "yes" {`
`639`	`640`	`return 1, nil`
`640`	`641`	`}`
`641`		`- if value.(string) == "False" \|\| value.(string) == "false" \|\| value.(string) == "No" \|\| value.(string) == "no" {`
	`642`	`+ if normalized == "false" \|\| normalized == "no" {`
`642`	`643`	`return 0, nil`
`643`	`644`	`}`
`644`	`645`	`if t, e := time.Parse(time.RFC3339, value.(string)); e == nil {`