kinder: switch to using the k-sigs/kindnet manifest and image #3284
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
approved
neolit123
changed the title
k8s-ci-robot
added
size/M
neolit123
force-pushed
the
1.36-switch-to-ksigs-kindnet
branch
from
c789c45 to
78992b3
Compare
carlory
reviewed
Feb 5, 2026
| @@ -204,7 +204,7 @@ func postInit(c *status.Cluster, wait time.Duration) error { | |||
| // Apply a CNI plugin using a hardcoded manifest | |||
| cmd := cp1.Command("kubectl", "apply", "--kubeconfig=/etc/kubernetes/admin.conf", "-f", "-") | |||
| cp1.Infof("applying kindnet version 0.5.4") | |||
Member
There was a problem hiding this comment.
Suggested change
| cp1.Infof("applying kindnet version 0.5.4") | |
| cp1.Infof("applying kindnet version 1.0.0") |
Only one nit.
Member
Author
There was a problem hiding this comment.
changed it to:
cp1.Infof("applying kindnet manifest for image %s...", assets.KindnetImage100)
that will still indicate the version in the logs.
(and when we bump we don't need to touch this line)
The image and manifest we used was from the original author repo github.com/aojea/kindnetd. The project was later donated to k-sigs/kindnet. Switch to using the latest image and manifest from the new project. The old manifest also included the verb 'nodes/proxy', which is vulnerable as discussed in k/kubeadm ticket 3283.
neolit123
force-pushed
the
1.36-switch-to-ksigs-kindnet
branch
from
78992b3 to
5830796
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image and manifest we used was from the original author repo github.com/aojea/kindnetd. The project was later donated to k-sigs/kindnet.
Switch to using the latest image and manifest from the new project.
The old manifest also included the verb 'nodes/proxy', which is vulnerable as discussed in k/kubeadm ticket 3283.
fixes #3283