Skip to content

Commit 673e8bb

Browse files
Add Docker runtime support to podman-env command
Extend podman-env compatibility to support both crio and docker container runtimes, providing users with more deployment flexibility while maintaining the core Docker API compatibility approach that eliminates API version conflicts. This change allows podman-env to work with: - Podman driver + crio runtime (original support) - Podman driver + docker runtime (new support) Both configurations use the same Docker API compatibility approach that was implemented to address reviewer feedback about SSH-based connectivity issues and API version mismatches.
1 parent 9a3bd3b commit 673e8bb

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

cmd/minikube/cmd/podman-env.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,10 @@ var podmanEnvCmd = &cobra.Command{
129129
exit.Message(reason.Usage, `The podman-env command is incompatible with multi-node clusters. Use the 'registry' add-on: https://minikube.sigs.k8s.io/docs/handbook/registry/`)
130130
}
131131

132-
if co.Config.KubernetesConfig.ContainerRuntime != constants.CRIO {
133-
exit.Message(reason.Usage, `The podman-env command is only compatible with the "crio" runtime, but this cluster was configured to use the "{{.runtime}}" runtime.`,
134-
out.V{"runtime": co.Config.KubernetesConfig.ContainerRuntime})
132+
cr := co.Config.KubernetesConfig.ContainerRuntime
133+
if cr != constants.CRIO && cr != constants.Docker {
134+
exit.Message(reason.Usage, `The podman-env command is only compatible with the "crio" and "docker" runtimes, but this cluster was configured to use the "{{.runtime}}" runtime.`,
135+
out.V{"runtime": cr})
135136
}
136137

137138
r := co.CP.Runner

0 commit comments

Comments
 (0)