Skip to content

Commit 6b397d8

Browse files
authored
gitignore: Ignore test/integration/licenses (#21267)
Running the function tests creates a licenses directory and checks out the "github.com/hooklift/iso9660" module, which imports "github.com/c4milo/gotoolkit". % git status ... Untracked files: (use "git add <file>..." to include in what will be committed) test/integration/licenses/ At this point running go mod tidy will add the gotoolkit module: % go mod tidy --diff diff current/go.mod tidy/go.mod --- current/go.mod +++ tidy/go.mod @@ -13,6 +13,7 @@ github.com/Xuanwo/go-locale v1.1.3 github.com/blang/semver/v4 v4.0.0 github.com/briandowns/spinner v1.23.2 + github.com/c4milo/gotoolkit v0.0.0-20190525173301-67483a18c17a github.com/cenkalti/backoff/v4 v4.3.0 github.com/cheggaaa/pb/v3 v3.1.7 github.com/cloudevents/sdk-go/v2 v2.16.0 ... "github.com/hooklift/iso9660" does not have a go.mod file, so `go mod tidy` treats is as part of the main module and update go.mod. We should find a better place to check out the licenses, maybe a test temporary directory, but let's start with quick fix: ignore the license directory, and include it in `make clean`.
1 parent 6b0b64e commit 6b397d8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ deploy/iso/minikube-iso/board/minikube/aarch64/rootfs-overlay/version.json
5353

5454
/.vscode
5555

56-
test/integration/testdata/minikube-linux-amd64-latest-stable
56+
/test/integration/testdata/minikube-linux-amd64-latest-stable
57+
/test/integration/licenses
5758

5859
# hugo
5960
/public

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -490,6 +490,7 @@ clean: ## Clean build
490490
rm -f pkg/minikube/translate/translations.go
491491
rm -rf ./vendor
492492
rm -rf /tmp/tmp.*.minikube_*
493+
rm -rf test/integration/licenses
493494

494495
.PHONY: gendocs
495496
gendocs: out/docs/minikube.md ## Generate documentation

0 commit comments

Comments
 (0)