move viper calls from packages into cmd to improve testability/resusablitily

[medyagh]

packages inside minikube should not be calling viper to get a config, the viper (getting confg flags) should only be called form Cmd packages

this will help better testing and also avoid race conditions in Setting or Getting Flags in Parallel testing and Parallel usage of minikube and make minikube code more reusable and more testable

Originally posted by @medyagh in #21635 (comment)

[nirs]

The viper calls have another big issue - they use literal strings with the flag names (e.g. "download-only"). We cannot use the actual names since the constant are not exported.

[nirs]

#21682 remove the download-only check form the vmnet package. This restore the state we had before fixing #21634.

Moving all viper calls from minikube is very hard since we need to get the flags through multiple packages, down to the Driver.SetupIP(), calling firewall.Unlock() which needs the --interactive flag.

• cmd/minikube/cmd
  • minikube/node
    • minikube/machine
      • minikube/registry/drvs
        • drivers/*

[nirs]

#21683 is an attempt to remove viper calls for --interactive, --download-only, and --delete-on-failure.

[nirs]

/assign