Skip to content

Commit 11816c7

Browse files
committed
Add ext4 and wait 300s
1 parent e459292 commit 11816c7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

test/e2e/metriconly/metrics_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,13 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
123123
ginkgo.Context("When ext4 filesystem error happens", func() {
124124

125125
ginkgo.BeforeEach(func() {
126-
err := npd.WaitForNPD(instance, []string{"problem_gauge"}, 120)
127-
Expect(err).NotTo(HaveOccurred(), fmt.Sprintf("Expect NPD to become ready in 120s, but hit error: %v", err))
126+
err := npd.WaitForNPD(instance, []string{"problem_gauge"}, 300)
127+
Expect(err).NotTo(HaveOccurred(), fmt.Sprintf("Expect NPD to become ready in 300s, but hit error: %v", err))
128128
// This will trigger a ext4 error on the boot disk, causing the boot disk mounted as read-only and systemd-journald crashing.
129129
instance.RunCommandOrFail("sudo /home/kubernetes/bin/problem-maker --problem Ext4FilesystemError")
130130
})
131131

132132
ginkgo.It("NPD should update problem_counter{reason:Ext4Error} and problem_gauge{type:ReadonlyFilesystem}", func() {
133-
ginkgo.Skip("SSH connection fails.")
134133
time.Sleep(5 * time.Second)
135134
assertMetricValueAtLeast(instance,
136135
"problem_counter", map[string]string{"reason": "Ext4Error"},
@@ -141,7 +140,6 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
141140
})
142141

143142
ginkgo.It("NPD should remain healthy", func() {
144-
ginkgo.Skip("SSH connection fails.")
145143
npdStates := instance.RunCommandOrFail("sudo systemctl show node-problem-detector -p ActiveState -p SubState")
146144
Expect(npdStates.Stdout).To(ContainSubstring("ActiveState=active"), "NPD is no longer active: %v", npdStates)
147145
Expect(npdStates.Stdout).To(ContainSubstring("SubState=running"), "NPD is no longer running: %v", npdStates)

0 commit comments

Comments
 (0)