Merge pull request #248 from nak3/add-required-flag

k8s-ci-robot · web-flow · commit 3feec9be04fb · 2019-01-16T21:42:17.000-08:00
Add validation for the required flag
diff --git a/cmd/options/options.go b/cmd/options/options.go
@@ -80,6 +80,9 @@ func (npdo *NodeProblemDetectorOptions) ValidOrDie() {
 		panic(fmt.Sprintf("apiserver-override %q is not a valid HTTP URI: %v",
 			npdo.ApiServerOverride, err))
 	}
+	if len(npdo.SystemLogMonitorConfigPaths) == 0 && len(npdo.CustomPluginMonitorConfigPaths) == 0 {
+		panic(fmt.Sprintf("Either --system-log-monitors or --custom-plugin-monitors is required"))
+	}
 }
 
 // SetNodeNameOrDie sets `NodeName` field with valid value.

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,9 @@ func (npdo *NodeProblemDetectorOptions) ValidOrDie() {`
`80`	`80`	`panic(fmt.Sprintf("apiserver-override %q is not a valid HTTP URI: %v",`
`81`	`81`	`npdo.ApiServerOverride, err))`
`82`	`82`	`}`
	`83`	`+ if len(npdo.SystemLogMonitorConfigPaths) == 0 && len(npdo.CustomPluginMonitorConfigPaths) == 0 {`
	`84`	`+ panic(fmt.Sprintf("Either --system-log-monitors or --custom-plugin-monitors is required"))`
	`85`	`+ }`
`83`	`86`	`}`
`84`	`87`
`85`	`88`	// SetNodeNameOrDie sets `NodeName` field with valid value.