fix(metrics): retain early nil return with no name

Author: daveoy

pkg/util/metrics/metric_float64.go

@@ -44,8 +44,12 @@ type Float64MetricInterface interface {
 	Record(labelValues map[string]string, value float64) error
 }
 
-// NewFloat64Metric creates a new Float64 metric using OpenTelemetry
+// NewFloat64Metric creates a new Float64 metric using OpenTelemetry, returns nil when name is empty
 func NewFloat64Metric(metricID MetricID, name, description, unit string, aggregation Aggregation, labels []string) (*Float64Metric, error) {
+	if name == "" {
+		return nil, nil
+	}
+
 	meter := otelutil.GetGlobalMeter()
 
 	otelMetric := &OTelFloat64Metric{

pkg/util/metrics/metric_int64.go

@@ -44,8 +44,12 @@ type Int64MetricInterface interface {
 	Record(labelValues map[string]string, value int64) error
 }
 
-// NewInt64Metric creates a new Int64 metric using OpenTelemetry
+// NewInt64Metric creates a new Int64 metric using OpenTelemetry, returns nil when name is empty
 func NewInt64Metric(metricID MetricID, name, description, unit string, aggregation Aggregation, labels []string) (*Int64Metric, error) {
+	if name == "" {
+		return nil, nil
+	}
+
 	meter := otelutil.GetGlobalMeter()
 
 	otelMetric := &OTelInt64Metric{