Skip to content

Commit 501e94b

Browse files
authored
Merge pull request #29 from Random-Liu/get-node-name-from-pod
NPD: Get node name from pod
2 parents 75c7bdb + 5a19ac1 commit 501e94b

File tree

4 files changed

+27
-7
lines changed

4 files changed

+27
-7
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
all: push
22

33
# See pod.yaml for the version currently running-- bump this ahead before rebuilding!
4-
TAG = v0.1
4+
TAG = v0.2
55

66
PROJ = google_containers
77

README.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,21 @@ metadata:
6666
spec:
6767
template:
6868
spec:
69-
hostNetwork: true
7069
containers:
7170
- name: node-problem-detector
72-
image: gcr.io/google_containers/node-problem-detector:v0.1
71+
image: gcr.io/google_containers/node-problem-detector:v0.2
7372
imagePullPolicy: Always
7473
securityContext:
7574
privileged: true
75+
env:
76+
- name: POD_NAME
77+
valueFrom:
78+
fieldRef:
79+
fieldPath: metadata.name
80+
- name: POD_NAMESPACE
81+
valueFrom:
82+
fieldRef:
83+
fieldPath: metadata.namespace
7684
volumeMounts:
7785
- name: log
7886
mountPath: /log

node-problem-detector.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,24 @@ spec:
88
labels:
99
app: node-problem-detector
1010
spec:
11-
hostNetwork: true
1211
containers:
1312
- name: node-problem-detector
1413
command:
1514
- /node-problem-detector
1615
- --kernel-monitor=/config/kernel-monitor.json
17-
image: gcr.io/google_containers/node-problem-detector:v0.1
16+
image: gcr.io/google.com/noogler-kubernetes/node-problem-detector:v0.2
1817
imagePullPolicy: Always
1918
securityContext:
2019
privileged: true
20+
env:
21+
- name: POD_NAME
22+
valueFrom:
23+
fieldRef:
24+
fieldPath: metadata.name
25+
- name: POD_NAMESPACE
26+
valueFrom:
27+
fieldRef:
28+
fieldPath: metadata.namespace
2129
volumeMounts:
2230
- name: log
2331
mountPath: /log

pkg/problemclient/problem_client.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,15 @@ func NewClientOrDie() Client {
5757
}
5858
// TODO(random-liu): Set QPS Limit
5959
c.client = client.NewOrDie(cfg)
60-
// TODO(random-liu): Get node name from cloud provider
61-
c.nodeName, err = os.Hostname()
60+
// Get node name from the current pod.
61+
pod, err := c.client.Pods(os.Getenv("POD_NAMESPACE")).Get(os.Getenv("POD_NAME"))
6262
if err != nil {
6363
panic(err)
6464
}
65+
if pod.Spec.NodeName == "" {
66+
panic("empty node name")
67+
}
68+
c.nodeName = pod.Spec.NodeName
6569
c.nodeRef = getNodeRef(c.nodeName)
6670
c.recorders = make(map[string]record.EventRecorder)
6771
return c

0 commit comments

Comments
 (0)