Skip to content

Commit 6204ad7

Browse files
authored
Merge pull request #194 from wangzhen127/fix-readme-gitignore
Add required package for Debian in README and ignore entire /bin/ dir
2 parents 11f553c + aef8fa6 commit 6204ad7

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
/bin/node-problem-detector
1+
/bin/
22
/Dockerfile
33
/*.tar.gz

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ For example, to run without auth, use the following config:
8181
* `--hostname-override`: A customized node name used for node-problem-detector to update conditions and emit events. node-problem-detector gets node name first from `hostname-override`, then `NODE_NAME` environment variable and finally fall back to `os.Hostname`.
8282

8383
## Build Image
84-
* `go get` or `git clone` node-problem-detector repo into `$GOPATH/src/k8s.io` or `$GOROOT/src/k8s.io`
84+
* `go get` or `git clone` node-problem-detector repo into `$GOPATH/src/k8s.io` or `$GOROOT/src/k8s.io`
8585
with one of the below directions:
8686
* `cd $GOPATH/src/k8s.io && git clone [email protected]:kubernetes/node-problem-detector.git`
8787
* `cd $GOROOT/src/k8s.io && git clone [email protected]:kubernetes/node-problem-detector.git`
@@ -92,9 +92,9 @@ with one of the below directions:
9292
* Build the docker image. The binary and `config/` are copied into the docker image.
9393

9494
**Note**:
95-
By default node-problem-detector will be built with systemd support with `make` command. This requires systemd develop files.
96-
You should download the systemd develop files first. For Ubuntu, `libsystemd-journal-dev` package should
97-
be installed.
95+
By default node-problem-detector will be built with systemd support with `make` command. This requires systemd develop files.
96+
You should download the systemd develop files first. For Ubuntu, `libsystemd-journal-dev` package should
97+
be installed. For Debian, `libsystemd-dev` package should be installed.
9898

9999
## Push Image
100100
`make push` uploads the docker image to registry. By default, the image will be uploaded to

0 commit comments

Comments
 (0)