Skip to content

Commit b51cb32

Browse files
committed
fix: print result's message when status unknown
Signed-off-by: zhangyue <[email protected]>
1 parent 8a41d4a commit b51cb32

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/custompluginmonitor/custom_plugin_monitor.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,10 @@ func (c *customPluginMonitor) generateStatus(result cpmtypes.Result) *types.Stat
188188
if condition.Status == types.True && status != types.True {
189189
// Scenario 1: Condition status changes from True to False/Unknown
190190
newReason = defaultConditionReason
191-
if newMessage == "" {
191+
if status == types.False {
192192
newMessage = defaultConditionMessage
193193
} else {
194+
// When status unknown, the result's message is important for debug
194195
newMessage = result.Message
195196
}
196197
} else if condition.Status != types.True && status == types.True {
@@ -200,9 +201,10 @@ func (c *customPluginMonitor) generateStatus(result cpmtypes.Result) *types.Stat
200201
} else if condition.Status != status {
201202
// Scenario 3: Condition status changes from False to Unknown or vice versa
202203
newReason = defaultConditionReason
203-
if newMessage == "" {
204+
if status == types.False {
204205
newMessage = defaultConditionMessage
205206
} else {
207+
// When status unknown, the result's message is important for debug
206208
newMessage = result.Message
207209
}
208210
} else if condition.Status == types.True && status == types.True &&

0 commit comments

Comments
 (0)