Skip to content

Commit c73095e

Browse files
authored
Merge pull request #1094 from hakman/fix-tests
Fix test instance name
2 parents df27bad + c00e4ec commit c73095e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/e2e/metriconly/metrics_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
5151
}
5252
instance, err = gce.CreateInstance(
5353
gce.Instance{
54-
Name: "npd-metrics-" + *image + "-" + uuid.NewUUID().String()[:8],
54+
Name: "npd-metrics-" + uuid.NewUUID().String()[:8],
5555
Zone: *zone,
5656
Project: *project,
5757
SshKey: *sshKey,
@@ -130,6 +130,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
130130
})
131131

132132
ginkgo.It("NPD should update problem_counter{reason:Ext4Error} and problem_gauge{type:ReadonlyFilesystem}", func() {
133+
ginkgo.Skip("Writing to /sys/fs/ext4/sda1/trigger_fs_error breaks SSH: https://github.com/kubernetes/node-problem-detector/issues/970")
133134
time.Sleep(5 * time.Second)
134135
assertMetricValueAtLeast(instance,
135136
"problem_counter", map[string]string{"reason": "Ext4Error"},
@@ -140,6 +141,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() {
140141
})
141142

142143
ginkgo.It("NPD should remain healthy", func() {
144+
ginkgo.Skip("Writing to /sys/fs/ext4/sda1/trigger_fs_error breaks SSH: https://github.com/kubernetes/node-problem-detector/issues/970")
143145
npdStates := instance.RunCommandOrFail("sudo systemctl show node-problem-detector -p ActiveState -p SubState")
144146
Expect(npdStates.Stdout).To(ContainSubstring("ActiveState=active"), "NPD is no longer active: %v", npdStates)
145147
Expect(npdStates.Stdout).To(ContainSubstring("SubState=running"), "NPD is no longer running: %v", npdStates)

0 commit comments

Comments
 (0)