From db782fe8d2f9997657838cc7f505b2c766476668 Mon Sep 17 00:00:00 2001 From: Ciprian Hacman Date: Mon, 11 Aug 2025 22:59:42 +0300 Subject: [PATCH 1/2] Fix test instance name --- test/e2e/metriconly/metrics_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/metriconly/metrics_test.go b/test/e2e/metriconly/metrics_test.go index 5d57a5852..9cea5fffa 100644 --- a/test/e2e/metriconly/metrics_test.go +++ b/test/e2e/metriconly/metrics_test.go @@ -51,7 +51,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() { } instance, err = gce.CreateInstance( gce.Instance{ - Name: "npd-metrics-" + *image + "-" + uuid.NewUUID().String()[:8], + Name: "npd-metrics-" + uuid.NewUUID().String()[:8], Zone: *zone, Project: *project, SshKey: *sshKey, From c00e4ec6cfff9e335ca9a17a18a4683a1c853965 Mon Sep 17 00:00:00 2001 From: Ciprian Hacman Date: Tue, 12 Aug 2025 04:39:42 +0300 Subject: [PATCH 2/2] Reapply "Skip ext4 e2e tests" This reverts commit 281a1187377dc7a1112cd52ea177a8eb784a9351. --- test/e2e/metriconly/metrics_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/e2e/metriconly/metrics_test.go b/test/e2e/metriconly/metrics_test.go index 9cea5fffa..cf0db18f5 100644 --- a/test/e2e/metriconly/metrics_test.go +++ b/test/e2e/metriconly/metrics_test.go @@ -130,6 +130,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() { }) ginkgo.It("NPD should update problem_counter{reason:Ext4Error} and problem_gauge{type:ReadonlyFilesystem}", func() { + ginkgo.Skip("Writing to /sys/fs/ext4/sda1/trigger_fs_error breaks SSH: https://github.com/kubernetes/node-problem-detector/issues/970") time.Sleep(5 * time.Second) assertMetricValueAtLeast(instance, "problem_counter", map[string]string{"reason": "Ext4Error"}, @@ -140,6 +141,7 @@ var _ = ginkgo.Describe("NPD should export Prometheus metrics.", func() { }) ginkgo.It("NPD should remain healthy", func() { + ginkgo.Skip("Writing to /sys/fs/ext4/sda1/trigger_fs_error breaks SSH: https://github.com/kubernetes/node-problem-detector/issues/970") npdStates := instance.RunCommandOrFail("sudo systemctl show node-problem-detector -p ActiveState -p SubState") Expect(npdStates.Stdout).To(ContainSubstring("ActiveState=active"), "NPD is no longer active: %v", npdStates) Expect(npdStates.Stdout).To(ContainSubstring("SubState=running"), "NPD is no longer running: %v", npdStates)