Skip to content

Commit 4da9269

Browse files
committed
fix lints
Signed-off-by: Carlos Panato <[email protected]>
1 parent ab665a2 commit 4da9269

File tree

4 files changed

+28
-15
lines changed

4 files changed

+28
-15
lines changed

cmd/ci-reporter/cmd/root.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,8 @@ func PrintReporterData(cfg *Config, reports *CIReportDataFields) error {
246246
if err != nil {
247247
return fmt.Errorf("could not write to output stream: %w", err)
248248
}
249-
data := [][]string{}
250249

250+
data := [][]string{}
251251
table := tablewriter.NewTable(out,
252252
tablewriter.WithConfig(tablewriter.Config{
253253
Header: tw.CellConfig{
@@ -292,8 +292,13 @@ func PrintReporterData(cfg *Config, reports *CIReportDataFields) error {
292292
}
293293
}
294294

295-
table.Append(data)
296-
table.Render()
295+
if err := table.Bulk(data); err != nil {
296+
return err
297+
}
298+
299+
if err := table.Render(); err != nil {
300+
return err
301+
}
297302

298303
// write a summary
299304
countCategories := map[string]int{}

cmd/schedule-builder/cmd/markdown.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,14 @@ func parsePatchSchedule(patchSchedule PatchSchedule) string {
7777
continue
7878
}
7979

80-
table.Append([]string{
80+
_ = table.Append([]string{
8181
targetDate.Format(refDateMonthly),
8282
strings.TrimSpace(upcoming.CherryPickDeadline),
8383
strings.TrimSpace(upcoming.TargetDate),
8484
})
8585
}
8686

87-
table.Render()
87+
_ = table.Render()
8888

8989
output = append(output, tableString.String())
9090
}
@@ -130,14 +130,14 @@ func parsePatchSchedule(patchSchedule PatchSchedule) string {
130130

131131
// Check if the next patch release is in the Previous Patch list, if yes dont read in the output
132132
if !patchReleaseInPreviousList(releaseSchedule.Next.Release, releaseSchedule.PreviousPatches) {
133-
table.Append([]string{strings.TrimSpace(releaseSchedule.Next.Release), strings.TrimSpace(releaseSchedule.Next.CherryPickDeadline), strings.TrimSpace(releaseSchedule.Next.TargetDate), ""})
133+
_ = table.Append([]string{strings.TrimSpace(releaseSchedule.Next.Release), strings.TrimSpace(releaseSchedule.Next.CherryPickDeadline), strings.TrimSpace(releaseSchedule.Next.TargetDate), ""})
134134
}
135135

136136
for _, previous := range releaseSchedule.PreviousPatches {
137-
table.Append([]string{strings.TrimSpace(previous.Release), strings.TrimSpace(previous.CherryPickDeadline), strings.TrimSpace(previous.TargetDate), strings.TrimSpace(previous.Note)})
137+
_ = table.Append([]string{strings.TrimSpace(previous.Release), strings.TrimSpace(previous.CherryPickDeadline), strings.TrimSpace(previous.TargetDate), strings.TrimSpace(previous.Note)})
138138
}
139139

140-
table.Render()
140+
_ = table.Render()
141141

142142
output = append(output, tableString.String())
143143
}
@@ -204,10 +204,10 @@ func parseReleaseSchedule(releaseSchedule ReleaseSchedule) string {
204204
)
205205

206206
for _, timeline := range releaseSchedule.Timeline {
207-
table.Append([]string{strings.TrimSpace(timeline.What), strings.TrimSpace(timeline.Who), strings.TrimSpace(timeline.When), strings.TrimSpace(timeline.Week), strings.TrimSpace(timeline.CISignal), ""})
207+
_ = table.Append([]string{strings.TrimSpace(timeline.What), strings.TrimSpace(timeline.Who), strings.TrimSpace(timeline.When), strings.TrimSpace(timeline.Week), strings.TrimSpace(timeline.CISignal), ""})
208208
}
209209

210-
table.Render()
210+
_ = table.Render()
211211

212212
relSched.TimelineOutput = tableString.String()
213213
}

pkg/gcp/build/build.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -419,10 +419,14 @@ func ListJobs(project string, lastJobs int64) error {
419419
)
420420

421421
for _, build := range req.Builds {
422-
table.Append([]string{strings.TrimSpace(build.StartTime), strings.TrimSpace(build.FinishTime), strings.TrimSpace(build.Status), strings.TrimSpace(build.LogUrl)})
422+
if err := table.Append([]string{strings.TrimSpace(build.StartTime), strings.TrimSpace(build.FinishTime), strings.TrimSpace(build.Status), strings.TrimSpace(build.LogUrl)}); err != nil {
423+
return err
424+
}
423425
}
424426

425-
table.Render()
427+
if err := table.Render(); err != nil {
428+
return err
429+
}
426430

427431
return nil
428432
}

pkg/gcp/gcb/history.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,13 +205,17 @@ func (h *History) Run() error {
205205
out := time.Time{}.Add(diff)
206206

207207
step := fmt.Sprintf("`%s%s`", mock, subcommand)
208-
table.Append([]string{
208+
if err := table.Append([]string{
209209
step, command, logs, start,
210210
out.Format("15:04:05"), status[job.Status],
211-
})
211+
}); err != nil {
212+
return fmt.Errorf("append row to table: %w", err)
213+
}
212214
}
213215

214-
table.Render()
216+
if err := table.Render(); err != nil {
217+
return err
218+
}
215219

216220
fmt.Print(tableString.String())
217221

0 commit comments

Comments
 (0)