Skip to content

Commit 53d7ee8

Browse files
committed
fix lints
Signed-off-by: Carlos Panato <[email protected]>
1 parent 4762931 commit 53d7ee8

File tree

9 files changed

+13
-1
lines changed

9 files changed

+13
-1
lines changed

cmd/krel/cmd/sign_blobs.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ func runSignBlobs(signOpts *signOptions, signBlobOpts *signBlobOptions, args []s
141141
}
142142

143143
var tempDir string
144+
144145
defer func() {
145146
if tempDir != "" {
146147
os.RemoveAll(tempDir)

cmd/publish-release/cmd/github_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@ func TestProcessRemoteAsset(t *testing.T) {
3030

3131
prev := os.Getenv(gacVar)
3232
defer t.Setenv(gacVar, prev)
33+
3334
t.Setenv(gacVar, "")
3435

3536
files := []string{}
37+
3638
defer func() {
3739
for _, f := range files {
3840
os.RemoveAll(f)

dependencies.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@ dependencies:
408408

409409
# golangci-lint-version
410410
- name: "golangci-lint"
411-
version: v2.1
411+
version: v2.3
412412
refPaths:
413413
- path: .github/workflows/lint.yml
414414
match: "version: v\\d+.\\d+?\\.?(\\d+)?"

pkg/binary/binary_unit_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
func TestContainsString(t *testing.T) {
2828
tmpfile, err := os.CreateTemp(t.TempDir(), "")
2929
require.NoError(t, err)
30+
3031
defer os.Remove(tmpfile.Name())
3132

3233
// Decode a fragment of kubectl into a temporary file:

pkg/gcp/build/build.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ func RunSingleJob(o *Options, jobName, uploaded, version string, subs map[string
254254
}
255255

256256
defer f.Close()
257+
257258
cmd.AddWriter(f)
258259
}
259260

@@ -362,6 +363,7 @@ func RunBuildJobs(o *Options) []error {
362363
for k, v := range vs {
363364
go func(job string, vc map[string]string) {
364365
defer w.Done()
366+
365367
logrus.Infof("Starting job %q...", job)
366368

367369
if err := RunSingleJob(o, job, uploaded, tag, mergeMaps(extraSubs, vc)); err != nil {

pkg/notes/document/document_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,7 @@ func setupTestDir(t *testing.T, dir string) {
279279

280280
func repoTagTarball(t *testing.T, path, repoTag string) {
281281
const manifestJSON = "manifest.json"
282+
282283
manifestJSONPath := filepath.Join(filepath.Dir(path), manifestJSON)
283284
require.NoError(t, os.WriteFile(
284285
manifestJSONPath,

pkg/notes/notes.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -653,6 +653,7 @@ type commitList struct {
653653
func (l *commitList) Add(c []*gogithub.RepositoryCommit) {
654654
l.Lock()
655655
defer l.Unlock()
656+
656657
l.list = append(l.list, c...)
657658
}
658659

@@ -917,6 +918,7 @@ type resultList struct {
917918
func (l *resultList) Add(r *Result) {
918919
l.Lock()
919920
defer l.Unlock()
921+
920922
l.list = append(l.list, r)
921923
}
922924

pkg/release/publish.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -465,6 +465,7 @@ func (p *Publisher) PublishReleaseNotesIndex(
465465
}
466466

467467
defer os.RemoveAll(tempDir)
468+
468469
tempIndexFile := filepath.Join(tempDir, releaseNotesIndex)
469470

470471
if err := p.client.CopyToLocal(

pkg/testgrid/testgrid-scraper.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ func ReqTestgridDashboardSummaries(ctx context.Context, dashboardNames []Dashboa
4040
// Worker
4141
requestData := func(done <-chan interface{}, dashboardNames ...DashboardName) <-chan SummaryLookup {
4242
summaryLookups := make(chan SummaryLookup)
43+
4344
go func() {
4445
defer close(summaryLookups)
4546

@@ -163,6 +164,7 @@ func (d *JobData) Overview() (Overview, error) {
163164
// UnmarshalTestgridSummary used to unmarshal bytes into TestgridSummary.
164165
func UnmarshalTestgridSummary(data []byte) (JobData, error) {
165166
var r JobData
167+
166168
err := json.Unmarshal(data, &r)
167169

168170
return r, err

0 commit comments

Comments
 (0)