Skip to content

Commit 843bffb

Browse files
committed
fix duplicate short hand, remove duplicated flags and mark depreated the create-website-pr
Signed-off-by: Carlos Panato <[email protected]>
1 parent 74c0237 commit 843bffb

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

cmd/krel/cmd/release_notes.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,11 +245,13 @@ func init() {
245245
releaseNotesCmd.PersistentFlags().StringSliceVarP(
246246
&releaseNotesOpts.includeLabels,
247247
"include-labels",
248-
"l",
248+
"",
249249
[]string{},
250250
"only PRs with one of these labels are considered. Set to empty to include all PRs",
251251
)
252252

253+
_ = releaseNotesCmd.PersistentFlags().MarkDeprecated("create-website-pr", "This flag is deprecated and will be removed in a future release. Use --create-draft-pr instead.")
254+
253255
rootCmd.AddCommand(releaseNotesCmd)
254256
}
255257

cmd/release-notes/generate.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -243,20 +243,6 @@ func addGenerateFlags(subcommand *cobra.Command) {
243243
[]string{},
244244
"specify a location to recursively look for release notes *.y[a]ml file mappings",
245245
)
246-
subcommand.PersistentFlags().BoolVar(
247-
&opts.ListReleaseNotesV2,
248-
"list-v2",
249-
false,
250-
"enable experimental implementation to list commits (ListReleaseNotesV2)",
251-
)
252-
253-
subcommand.PersistentFlags().StringSliceVarP(
254-
&opts.IncludeLabels,
255-
"include-labels",
256-
"l",
257-
[]string{},
258-
"Only PRs with one of these labels are considered. Set to empty to include all PRs",
259-
)
260246
}
261247

262248
// addGenerate adds the generate subcomand to the main release notes cobra cmd.

0 commit comments

Comments
 (0)