fix QF1002 / QF1003 could use tagged switch

Author: BenTheElder

kubetest/kops.go

@@ -675,7 +675,8 @@ func (k kops) BuildTester(o *e2e.BuildTesterOptions) (e2e.Tester, error) {
 		t.KubeMasterURL = kubecfg.Clusters[0].Cluster.Server
 	}
 
-	if k.provider == "gce" {
+	switch k.provider {
+	case "gce":
 		t.GCEProject = k.gcpProject
 		if len(k.zones) > 0 {
 			zone := k.zones[0]
@@ -688,7 +689,7 @@ func (k kops) BuildTester(o *e2e.BuildTesterOptions) (e2e.Tester, error) {
 			}
 			t.GCERegion = zone[0:lastDash]
 		}
-	} else if k.provider == "aws" {
+	case "aws":
 		if len(k.zones) > 0 {
 			zone := k.zones[0]
 			// These GCE fields are actually provider-agnostic

label_sync/main.go

@@ -765,16 +765,16 @@ func main() {
 		logrus.Fatalf("--only and --orgs cannot both be set")
 	}
 
-	switch {
-	case o.action == "docs":
+	switch o.action {
+	case "docs":
 		if err := writeDocs(o.docsTemplate, o.docsOutput, *config); err != nil {
 			logrus.WithError(err).Fatalf("failed to write docs using docs-template %s to docs-output %s", o.docsTemplate, o.docsOutput)
 		}
-	case o.action == "css":
+	case "css":
 		if err := writeCSS(o.cssTemplate, o.cssOutput, *config); err != nil {
 			logrus.WithError(err).Fatalf("failed to write css file using css-template %s to css-output %s", o.cssTemplate, o.cssOutput)
 		}
-	case o.action == "sync":
+	case "sync":
 		var githubClient client
 		var err error
 		if deprecated {

pkg/benchmarkjunit/parse.go

@@ -163,15 +163,16 @@ func parse(raw []byte) (*junit.Suites, error) {
 		case reActionLine.MatchString(line):
 			match := reActionLine.FindStringSubmatch(line)
 			emptyText := "" // Will be replaced with real text once output is read.
-			if match[1] == "SKIP" {
+			switch match[1] {
+			case "SKIP":
 				suite.Results = append(suite.Results, junit.Result{
 					ClassName: path.Base(suite.Name),
 					Name:      match[2],
 					Skipped: &junit.Skipped{
 						Value: emptyText,
 					},
 				})
-			} else if match[1] == "FAIL" {
+			case "FAIL":
 				suite.Results = append(suite.Results, junit.Result{
 					ClassName: path.Base(suite.Name),
 					Name:      match[2],