Skip to content

Commit 3ebdc6e

Browse files
committed
scheduler_perf: KUBE_CACHE_MUTATION_DETECTOR=false
As explained in kubernetes/kubernetes#134010, we want to measure performance of real production scheduling, which has the client-go cache mutation disabled. To avoid getting this enabled for us by "make test-integration", we have to explicitly disable it.
1 parent 0eeaeb8 commit 3ebdc6e

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -746,6 +746,8 @@ periodics:
746746
args:
747747
- ./test/integration/scheduler_perf/...
748748
env:
749+
- name: KUBE_CACHE_MUTATION_DETECTOR
750+
value: "false"
749751
- name: KUBE_TIMEOUT
750752
value: --timeout=3h55m
751753
# Keep the unprocessed `go test` JSON output for debugging.

config/jobs/kubernetes/sig-scheduling/sig-scheduling-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ presubmits:
8080
args:
8181
- /bin/sh
8282
- -c
83-
- ./hack/install-etcd.sh && PATH=${PWD}/third_party/etcd:${PATH} make test-integration WHAT=./test/integration/scheduler_perf/... KUBE_TIMEOUT=--timeout=3h55m ETCD_LOGLEVEL=warn KUBE_TEST_ARGS="-run=nothing-because-no-test-has-this-name -benchtime=1ns -bench=BenchmarkPerfScheduling -data-items-dir=${ARTIFACTS}" SHORT='--short=false' KUBE_PRUNE_JUNIT_TESTS=false
83+
- ./hack/install-etcd.sh && PATH=${PWD}/third_party/etcd:${PATH} make test-integration WHAT=./test/integration/scheduler_perf/... KUBE_CACHE_MUTATION_DETECTOR=false KUBE_TIMEOUT=--timeout=3h55m ETCD_LOGLEVEL=warn KUBE_TEST_ARGS="-run=nothing-because-no-test-has-this-name -benchtime=1ns -bench=BenchmarkPerfScheduling -data-items-dir=${ARTIFACTS}" SHORT='--short=false' KUBE_PRUNE_JUNIT_TESTS=false
8484
# We need to constraint compute resources so all the tests
8585
# finish approximately at the same time. More compute power
8686
# can increase scheduling throughput and make consequent results

0 commit comments

Comments
 (0)