Skip to content

Commit 483fd66

Browse files
authored
Merge pull request #33943 from pohly/apidiff-simplification
apidiff: cleanup
2 parents 235dd62 + 3ee3458 commit 483fd66

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

config/jobs/kubernetes/sig-testing/apidiff.yaml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,9 @@ presubmits:
3737
args:
3838
- /bin/sh
3939
- -c
40-
# PULL_BASE_SHA is the revision on the target branch that the
41-
# PR gets merged into. What we want instead is the revision at
42-
# which the PR branch diverged from the target branch.
43-
# We get that from "git merge-base".
44-
#
40+
# Base and target are detected automatically by the script based on Prow variables.
4541
# -b can be used more than once.
46-
- "./hack/apidiff.sh -r $(git merge-base ${PULL_BASE_SHA} ${PULL_PULL_SHA}) -t ${PULL_PULL_SHA} -b ${GOPATH}/src/sigs.k8s.io/controller-runtime"
47-
env:
48-
- name: REPO_DIR
49-
value: /workspace/k8s.io/kubernetes
42+
- "./hack/apidiff.sh -b ${GOPATH}/src/sigs.k8s.io/controller-runtime"
5043
resources:
5144
# Memory limits are derived from pull-kubernetes-verify, with less CPUs.
5245
limits:
@@ -61,7 +54,7 @@ presubmits:
6154
# A job which automatically runs for changes in client-go or the generated code
6255
# to have visibility on the changes that will impact the external projects
6356
# that are using the Kubernetes golang clients
64-
run_if_changed: '(^staging\/src\/k8s.io\/client-go)|(^staging\/src\/k8s.io\/code-generator\/examples)'
57+
run_if_changed: '((^staging\/src\/k8s.io\/client-go)|(^staging\/src\/k8s.io\/code-generator\/examples))/.*\.go'
6558
optional: true
6659
decorate: true
6760
annotations:
@@ -81,6 +74,7 @@ presubmits:
8174
args:
8275
- /bin/sh
8376
- -c
77+
# Base and target are detected automatically by the script based on Prow variables.
8478
- "./hack/apidiff.sh ./staging/src/k8s.io/code-generator/examples ./staging/src/k8s.io/client-go"
8579
resources:
8680
# Memory limits are derived from pull-kubernetes-verify, with less CPUs.

0 commit comments

Comments
 (0)