File tree Expand file tree Collapse file tree 2 files changed +9
-4
lines changed
experiment/compatibility-versions Expand file tree Collapse file tree 2 files changed +9
-4
lines changed Original file line number Diff line number Diff line change 33# TODO(#34269) update owners in experiment/compatibility-versions to a group/rotation and route the alert email to a rotation vs individual email
44reviewers:
55- aaron-prindle
6+ - siyuanfoundation
67approvers:
78- aaron-prindle
9+ - siyuanfoundation
Original file line number Diff line number Diff line change @@ -254,10 +254,13 @@ for feature_name in "${!actual_features[@]}"; do
254254 if grep -q " $feature_name " staging/src/k8s.io/client-go/features/known_features.go; then
255255 continue
256256 fi
257- # Check if gate is deprecated feature gate at the same version as the binary version
258- # OR if it's a GA feature with version 1.0
259- if [[ -n " ${current_version_stage[$feature_name]:- } " && " ${current_version_stage[$feature_name]} " == " DEPRECATED" ]] || \
260- [[ -n " ${version_1_0_stage[$feature_name]:- } " && " ${version_1_0_stage[$feature_name]} " == " GA" ]]; then
257+ # Check if gate is:
258+ # - 1. DEPRECATED feature gate at the same version as the binary version
259+ # - 2. GA feature with version 1.0 (used for code deprecation backfilling)
260+ # - 3. BETA feature with version 1.0 (used for bug fixes bound to binary version instead of emulation version)
261+ if [[ -n " ${current_version_stage[$feature_name]:- } " == " DEPRECATED" ]] || \
262+ [[ -n " ${version_1_0_stage[$feature_name]:- } " == " BETA" ]] || \
263+ [[ -n " ${version_1_0_stage[$feature_name]:- } " == " GA" ]]; then
261264 continue
262265 fi
263266 echo " FAIL: unexpected feature '$feature_name ' found in /metrics, got=1" \
You can’t perform that action at this time.
0 commit comments