Skip to content

Commit 71769fe

Browse files
authored
Merge pull request #34967 from pohly/dra-version-skew
DRA canary: fix determining previous release
2 parents c96280c + cb7785b commit 71769fe

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

config/jobs/kubernetes/sig-node/dra-canary.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -224,10 +224,10 @@ presubmits:
224224
previous_minor=$((minor - 1))
225225
# latest-*.txt is only the latest release candidate and can be lower than stable-*.txt.
226226
# Pick whatever is more recent to ensure that we cover release candidates for older patch releases.
227-
$ TODO: only in the periodic job. In the presubmit, test against a known-good previous release.
228-
previous=$((curl --silent -L https://dl.k8s.io/release/latest-$major.$previous_minor.txt && echo && curl --silent -L https://dl.k8s.io/release/stable-$major.$previous_minor.txt && echo) | sort -n | tail -1)
227+
# TODO: only in the periodics? Otherwise https://dl.k8s.io/release/stable-$major.$previous_minor.txt
228+
previous=$(curl --silent -L "https://dl.k8s.io/ci/latest-$major.$previous_minor.txt" )
229229
worker_image=dra/node:skewed1
230-
kind build node-image --image="$worker_image" "https://dl.k8s.io/$previous/kubernetes-server-linux-amd64.tar.gz"
230+
kind build node-image --image="$worker_image" "https://dl.k8s.io/ci/$previous/kubernetes-server-linux-amd64.tar.gz"
231231
# We might need support for disabling tests which need a recent kubelet. We'll see...
232232
GINKGO_E2E_PID=
233233
trap 'if [ "${GINKGO_E2E_PID}" ]; then kill -TERM "${GINKGO_E2E_PID}"; fi' TERM
@@ -320,10 +320,10 @@ presubmits:
320320
previous_minor=$((minor - 2))
321321
# latest-*.txt is only the latest release candidate and can be lower than stable-*.txt.
322322
# Pick whatever is more recent to ensure that we cover release candidates for older patch releases.
323-
$ TODO: only in the periodic job. In the presubmit, test against a known-good previous release.
324-
previous=$((curl --silent -L https://dl.k8s.io/release/latest-$major.$previous_minor.txt && echo && curl --silent -L https://dl.k8s.io/release/stable-$major.$previous_minor.txt && echo) | sort -n | tail -1)
323+
# TODO: only in the periodics? Otherwise https://dl.k8s.io/release/stable-$major.$previous_minor.txt
324+
previous=$(curl --silent -L "https://dl.k8s.io/ci/latest-$major.$previous_minor.txt" )
325325
worker_image=dra/node:skewed2
326-
kind build node-image --image="$worker_image" "https://dl.k8s.io/$previous/kubernetes-server-linux-amd64.tar.gz"
326+
kind build node-image --image="$worker_image" "https://dl.k8s.io/ci/$previous/kubernetes-server-linux-amd64.tar.gz"
327327
# We might need support for disabling tests which need a recent kubelet. We'll see...
328328
GINKGO_E2E_PID=
329329
trap 'if [ "${GINKGO_E2E_PID}" ]; then kill -TERM "${GINKGO_E2E_PID}"; fi' TERM

config/jobs/kubernetes/sig-node/dra.jinja

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,13 @@ presubmits:
120120
{%- if canary %}
121121
{%- if ci %}
122122
# A CI job uses pre-built release artifacts and pulls necessary source files from GitHub.
123-
revision=$(curl --fail --silent --show-error --location ${CI_URL}/${LATEST_TXT})
123+
revision=$(curl --fail --silent --show-error --location https://dl.k8s.io/ci/fast/latest-fast.txt)
124124
# Report what was tested.
125125
echo "{\"revision\":\"$revision\"}" >"${ARTIFACTS}/metadata.json"
126126
# git hash from e.g. v1.33.0-alpha.1.161+e62ce1c9db2dad
127127
hash=${revision/*+/}
128128
kind_yaml_cmd=(curl --fail --silent --show-error --location "https://raw.githubusercontent.com/kubernetes/kubernetes/$hash/test/e2e/dra/kind.yaml")
129-
kind_node_source="${CI_URL}/$revision/kubernetes-server-linux-amd64.tar.gz"
129+
kind_node_source="https://dl.k8s.io/ci/fast/$revision/kubernetes-server-linux-amd64.tar.gz"
130130
{%- else %}
131131
# A presubmit job uses the checked out and merged source code.
132132
revision=$(git describe --tags)
@@ -141,7 +141,7 @@ presubmits:
141141
features=( )
142142
{%- endif %}
143143
{%- if ci %}
144-
curl --fail --silent --show-error --location "${CI_URL}/$revision/kubernetes-test-linux-amd64.tar.gz" | tar zxvf -
144+
curl --fail --silent --show-error --location "https://dl.k8s.io/ci/fast/$revision/kubernetes-test-linux-amd64.tar.gz" | tar zxvf -
145145
ginkgo=kubernetes/test/bin/ginkgo
146146
e2e_test=kubernetes/test/bin/e2e.test
147147
{%- else %}
@@ -159,10 +159,10 @@ presubmits:
159159
previous_minor=$((minor - {{kubelet_skew}}))
160160
# latest-*.txt is only the latest release candidate and can be lower than stable-*.txt.
161161
# Pick whatever is more recent to ensure that we cover release candidates for older patch releases.
162-
$ TODO: only in the periodic job. In the presubmit, test against a known-good previous release.
163-
previous=$((curl --silent -L https://dl.k8s.io/release/latest-$major.$previous_minor.txt && echo && curl --silent -L https://dl.k8s.io/release/stable-$major.$previous_minor.txt && echo) | sort -n | tail -1)
162+
# TODO: only in the periodics? Otherwise https://dl.k8s.io/release/stable-$major.$previous_minor.txt
163+
previous=$(curl --silent -L "https://dl.k8s.io/ci/latest-$major.$previous_minor.txt" )
164164
worker_image=dra/node:skewed{{kubelet_skew}}
165-
kind build node-image --image="$worker_image" "https://dl.k8s.io/$previous/kubernetes-server-linux-amd64.tar.gz"
165+
kind build node-image --image="$worker_image" "https://dl.k8s.io/ci/$previous/kubernetes-server-linux-amd64.tar.gz"
166166
# We might need support for disabling tests which need a recent kubelet. We'll see...
167167
{%- else %}
168168
worker_image="$control_plane_image"

0 commit comments

Comments
 (0)