Skip to content

Commit b9a3b1d

Browse files
committed
test: Update filter for ResourceHealthStatus presubmit job
This commit updates the Ginkgo label filter for the `pull-kubernetes-node-e2e-resource-health-status` presubmit job. The new filter, `'Alpha && FeatureGate:ResourceHealthStatus'`, correctly selects all end-to-end tests for the `ResourceHealthStatus` feature. This includes both the original Device Plugin tests and the new DRA tests, ensuring comprehensive test coverage in a single job. This change is dependent on a corresponding update in `kubernetes/kubernetes` to standardize the test labels, ensuring they are all consistently marked with `[FeatureGate:ResourceHealthStatus]`. The filter was validated using the following dry-run command, which confirmed that all 4 relevant tests are now correctly selected: `go test -v ./test/e2e_node -args --feature-gates=ResourceHealthStatus=true --ginkgo.dry-run --ginkgo.v --ginkgo.silence-skips --ginkgo.label-filter='Alpha && FeatureGate:ResourceHealthStatus'`
1 parent 3e34b18 commit b9a3b1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3421,7 +3421,7 @@ presubmits:
34213421
- '--node-test-args=--feature-gates="ResourceHealthStatus=true" --service-feature-gates="ResourceHealthStatus=true" --runtime-config=api/alpha=true,api/beta=true --container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags="--fail-cgroupv1=true --cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd\"]}"'
34223422
- --node-tests=true
34233423
- --provider=gce
3424-
- '--test_args=--timeout=1h --label-filter="Feature: containsAny ResourceHealthStatus && Feature: isSubsetOf ResourceHealthStatus && !Flaky && !Slow"'
3424+
- '--test_args=--timeout=1h --label-filter="Alpha && FeatureGate:ResourceHealthStatus && !Flaky && !Slow"'
34253425
- --timeout=65m
34263426
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/containerd/containerd-main/cgroupv2/image-config-cgroupv2.yaml
34273427
resources:

0 commit comments

Comments
 (0)