fix QF1004: could use strings.ReplaceAll instead

Author: BenTheElder

images/builder/main.go

@@ -214,7 +214,7 @@ func runSingleJob(o options, jobName, uploaded, version string, subs map[string]
 
 	var logFilePath string
 	if o.logDir != "" {
-		logFilePath = path.Join(o.logDir, strings.Replace(jobName, "/", "-", -1)+".log")
+		logFilePath = path.Join(o.logDir, strings.ReplaceAll(jobName, "/", "-")+".log")
 		f, err := os.Create(logFilePath)
 
 		if err != nil {

kubetest/aksengine.go

@@ -204,7 +204,7 @@ func (c *aksEngineDeployer) SetCustomCloudProfileEnvironment() error {
 	if c.isAzureStackCloud() {
 		env := azure.Environment{}
 		env.Name = c.azureEnvironment
-		azsFQDNSuffix := strings.Replace(c.azureCustomCloudURL, fmt.Sprintf("https://portal.%s.", c.location), "", -1)
+		azsFQDNSuffix := strings.ReplaceAll(c.azureCustomCloudURL, fmt.Sprintf("https://portal.%s.", c.location), "")
 		azsFQDNSuffix = strings.TrimSuffix(azsFQDNSuffix, "/")
 		env.ResourceManagerEndpoint = fmt.Sprintf("https://management.%s.%s/", c.location, azsFQDNSuffix)
 		metadataURL := fmt.Sprintf("%s/metadata/endpoints?api-version=1.0", strings.TrimSuffix(env.ResourceManagerEndpoint, "/"))

label_sync/main.go

@@ -190,7 +190,7 @@ func writeTemplate(templatePath string, outputPath string, data interface{}) err
 	// set up template
 	funcMap := template.FuncMap{
 		"anchor": func(input string) string {
-			return strings.Replace(input, ":", " ", -1)
+			return strings.ReplaceAll(input, ":", " ")
 		},
 	}
 	t, err := template.New(filepath.Base(templatePath)).Funcs(funcMap).ParseFiles(templatePath)
@@ -930,7 +930,7 @@ func writeDocs(template string, output string, config Configuration) error {
 // I could not find a proper doc, so rules here a mostly empirical
 func linkify(text string) string {
 	// swap space with dash
-	link := strings.Replace(text, " ", "-", -1)
+	link := strings.ReplaceAll(text, " ", "-")
 	// discard some special characters
 	discard, _ := regexp.Compile("[,/]")
 	link = discard.ReplaceAllString(link, "")