Skip to content

Commit bc7ca5b

Browse files
committed
DRA: avoid redundant extra_refs
extra_refs without anything listed is harmless, but it's nicer to not have it. The downside is an additional if check in the template.
1 parent 4e43008 commit bc7ca5b

File tree

4 files changed

+2
-16
lines changed

4 files changed

+2
-16
lines changed

config/jobs/kubernetes/sig-node/dra-canary.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ presubmits:
2121
decoration_config:
2222
timeout: 90m
2323
path_alias: k8s.io/kubernetes
24-
extra_refs:
2524
spec:
2625
containers:
2726
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -106,7 +105,6 @@ presubmits:
106105
decoration_config:
107106
timeout: 90m
108107
path_alias: k8s.io/kubernetes
109-
extra_refs:
110108
spec:
111109
containers:
112110
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -193,7 +191,6 @@ presubmits:
193191
decoration_config:
194192
timeout: 90m
195193
path_alias: k8s.io/kubernetes
196-
extra_refs:
197194
spec:
198195
containers:
199196
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -280,7 +277,6 @@ presubmits:
280277
decoration_config:
281278
timeout: 90m
282279
path_alias: k8s.io/kubernetes
283-
extra_refs:
284280
spec:
285281
containers:
286282
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -388,7 +384,6 @@ presubmits:
388384
decoration_config:
389385
timeout: 90m
390386
path_alias: k8s.io/kubernetes
391-
extra_refs:
392387
spec:
393388
containers:
394389
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -496,7 +491,6 @@ presubmits:
496491
decoration_config:
497492
timeout: 90m
498493
path_alias: k8s.io/kubernetes
499-
extra_refs:
500494
spec:
501495
containers:
502496
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master

config/jobs/kubernetes/sig-node/dra-ci.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ periodics:
1919
decorate: true
2020
decoration_config:
2121
timeout: 90m
22-
extra_refs:
2322
spec:
2423
containers:
2524
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -104,7 +103,6 @@ periodics:
104103
decorate: true
105104
decoration_config:
106105
timeout: 90m
107-
extra_refs:
108106
spec:
109107
containers:
110108
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -194,7 +192,6 @@ periodics:
194192
decorate: true
195193
decoration_config:
196194
timeout: 90m
197-
extra_refs:
198195
spec:
199196
containers:
200197
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -306,7 +303,6 @@ periodics:
306303
decorate: true
307304
decoration_config:
308305
timeout: 90m
309-
extra_refs:
310306
spec:
311307
containers:
312308
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master

config/jobs/kubernetes/sig-node/dra-presubmit.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ presubmits:
2323
decoration_config:
2424
timeout: 90m
2525
path_alias: k8s.io/kubernetes
26-
extra_refs:
2726
spec:
2827
containers:
2928
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -110,7 +109,6 @@ presubmits:
110109
decoration_config:
111110
timeout: 90m
112111
path_alias: k8s.io/kubernetes
113-
extra_refs:
114112
spec:
115113
containers:
116114
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -198,7 +196,6 @@ presubmits:
198196
decoration_config:
199197
timeout: 90m
200198
path_alias: k8s.io/kubernetes
201-
extra_refs:
202199
spec:
203200
containers:
204201
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -287,7 +284,6 @@ presubmits:
287284
decoration_config:
288285
timeout: 90m
289286
path_alias: k8s.io/kubernetes
290-
extra_refs:
291287
spec:
292288
containers:
293289
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -397,7 +393,6 @@ presubmits:
397393
decoration_config:
398394
timeout: 90m
399395
path_alias: k8s.io/kubernetes
400-
extra_refs:
401396
spec:
402397
containers:
403398
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master
@@ -507,7 +502,6 @@ presubmits:
507502
decoration_config:
508503
timeout: 90m
509504
path_alias: k8s.io/kubernetes
510-
extra_refs:
511505
spec:
512506
containers:
513507
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master

config/jobs/kubernetes/sig-node/dra.jinja

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ presubmits:
6464
{%- if not ci %}
6565
path_alias: k8s.io/kubernetes
6666
{%- endif %}
67+
{%- if ci and need_kubernetes_repo or need_test_infra_repo or need_containerd_20_repo %}
6768
extra_refs:
6869
{%- if ci and need_kubernetes_repo %}
6970
- org: kubernetes
@@ -83,6 +84,7 @@ presubmits:
8384
repo: containerd
8485
base_ref: release/2.0
8586
{%- endif %}
87+
{%- endif %}
8688
spec:
8789
containers:
8890
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250714-70266d743a-master

0 commit comments

Comments
 (0)