Skip to content

Commit e34aeb2

Browse files
authored
Merge pull request #35789 from mariafromano-25/cleanup-sidecar-test-infra
Remove sidecarContainer test lane and from other test feature args
2 parents ebf1046 + cb4d2e1 commit e34aeb2

File tree

6 files changed

+10
-57
lines changed

6 files changed

+10
-57
lines changed

config/jobs/kubernetes/kops/build_jobs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1303,7 +1303,7 @@ def generate_misc():
13031303
"--set=spec.kubeAPIServer.runtimeConfig=api/all=true"
13041304
],
13051305
kubernetes_feature_gates="AllAlpha,AllBeta,-EventedPLEG",
1306-
focus_regex=r'\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking',
1306+
focus_regex=r'\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking',
13071307
skip_regex=r'\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0',
13081308
test_timeout_minutes=240,
13091309
test_parallelism=4,
@@ -1327,7 +1327,7 @@ def generate_misc():
13271327
"--gce-service-account=default",
13281328
],
13291329
kubernetes_feature_gates="AllAlpha,AllBeta,-EventedPLEG",
1330-
focus_regex=r'\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking',
1330+
focus_regex=r'\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking',
13311331
skip_regex=r'\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0',
13321332
test_timeout_minutes=240,
13331333
test_parallelism=4,

config/jobs/kubernetes/kops/kops-periodics-misc2.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3278,7 +3278,7 @@ periodics:
32783278
--test-package-url=https://storage.googleapis.com/k8s-release-dev \
32793279
--test-package-dir=ci \
32803280
--test-package-marker=latest.txt \
3281-
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
3281+
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
32823282
--skip-regex="\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0" \
32833283
--parallel=4
32843284
env:
@@ -3347,7 +3347,7 @@ periodics:
33473347
--test-package-url=https://storage.googleapis.com/k8s-release-dev \
33483348
--test-package-dir=ci \
33493349
--test-package-marker=latest.txt \
3350-
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
3350+
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
33513351
--skip-regex="\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0" \
33523352
--parallel=4
33533353
env:

config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ presubmits:
587587
- --gcp-region=us-central1
588588
- --provider=gce
589589
- --runtime-config=api/all=true
590-
- --test_args=--ginkgo.focus=\[Feature:(WatchList|InPlacePodVerticalScaling|APIServerTracing|SidecarContainers|StorageVersionAPI|PodPreset|PodLifecycleSleepAction|PodLifecycleSleepActionAllowZero|RecoverVolumeExpansionFailure)\] --ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0|\[KubeUp\] --minStartupPods=8
590+
- --test_args=--ginkgo.focus=\[Feature:(WatchList|InPlacePodVerticalScaling|APIServerTracing|StorageVersionAPI|PodPreset|PodLifecycleSleepAction|PodLifecycleSleepActionAllowZero|RecoverVolumeExpansionFailure)\] --ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0|\[KubeUp\] --minStartupPods=8
591591
- --timeout=180m
592592
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20251021-e2c2c9806f-master
593593
resources:
@@ -1055,7 +1055,7 @@ periodics:
10551055
- --gcp-region=us-central1
10561056
- --provider=gce
10571057
- --runtime-config=api/all=true
1058-
- --test_args=--ginkgo.focus=\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking --ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance|Example)\]|IPv6|csi-hostpath-v0 --minStartupPods=8
1058+
- --test_args=--ginkgo.focus=\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking --ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance|Example)\]|IPv6|csi-hostpath-v0 --minStartupPods=8
10591059
- --timeout=180m
10601060
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20251021-e2c2c9806f-master
10611061
resources:

config/jobs/kubernetes/sig-cloud-provider/periodic-e2e.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ periodics:
181181
--test-package-url=https://dl.k8s.io/ \
182182
--test-package-dir=ci/fast \
183183
--test-package-marker=latest-fast.txt \
184-
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
184+
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
185185
--skip-regex="\[Feature:(SCTPConnectivity|Volumes|Networking-Performance|Example)\]|IPv6|csi-hostpath-v0" \
186186
--parallel=25
187187
env:

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

Lines changed: 1 addition & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -669,53 +669,6 @@ presubmits:
669669
requests:
670670
cpu: 4
671671
memory: 6Gi
672-
- name: pull-kubernetes-node-kubelet-serial-containerd-sidecar-containers
673-
cluster: k8s-infra-prow-build
674-
always_run: false
675-
optional: true
676-
skip_report: false
677-
skip_branches:
678-
- release-\d+\.\d+ # per-release image
679-
annotations:
680-
testgrid-dashboards: sig-node-presubmits
681-
testgrid-tab-name: pr-node-kubelet-serial-containerd-sidecar-containers
682-
labels:
683-
preset-service-account: "true"
684-
preset-k8s-ssh: "true"
685-
decorate: true
686-
decoration_config:
687-
timeout: 260m
688-
path_alias: k8s.io/kubernetes
689-
extra_refs:
690-
- org: kubernetes
691-
repo: test-infra
692-
base_ref: master
693-
path_alias: k8s.io/test-infra
694-
spec:
695-
containers:
696-
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20251021-e2c2c9806f-master
697-
command:
698-
- runner.sh
699-
- /workspace/scenarios/kubernetes_e2e.py
700-
args:
701-
- --deployment=node
702-
- --gcp-zone=us-central1-b
703-
- --node-args=--image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/containerd/image-config-serial-resource-managers.yaml
704-
- '--node-test-args=--feature-gates=SidecarContainers=true --service-feature-gates=SidecarContainers=true --container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd*\"]}"'
705-
- --node-tests=true
706-
- --provider=gce
707-
- '--test_args=--nodes=1 --timeout=4h --label-filter="Serial && Feature: containsAny SidecarContainers && !Flaky && !Benchmark && !(Feature: containsAny Eviction)"'
708-
- --timeout=240m
709-
env:
710-
- name: GOPATH
711-
value: /go
712-
resources:
713-
limits:
714-
cpu: 4
715-
memory: 6Gi
716-
requests:
717-
cpu: 4
718-
memory: 6Gi
719672
- name: pull-kubernetes-node-kubelet-serial-containerd-kubetest2
720673
cluster: k8s-infra-prow-build
721674
# explicitly needs /test pull-kubernetes-node-kubelet-serial-containerd-kubetest2 to run
@@ -916,7 +869,7 @@ presubmits:
916869
--test-package-url=https://dl.k8s.io/ \
917870
--test-package-dir=ci/fast \
918871
--test-package-marker=latest-fast.txt \
919-
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
872+
--focus-regex="\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking" \
920873
--skip-regex="\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0" \
921874
--parallel=25
922875
env:

releng/test_config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ testSuites:
277277
# Panic if anything mutates a shared informer cache
278278
- --env=ENABLE_CACHE_MUTATION_DETECTOR=true
279279
- --runtime-config=api/all=true
280-
- --test_args=--ginkgo.focus=\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking
280+
- --test_args=--ginkgo.focus=\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking
281281
--ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance|Example)\]|IPv6|csi-hostpath-v0
282282
--minStartupPods=8
283283
cluster: k8s-infra-prow-build
@@ -290,7 +290,7 @@ testSuites:
290290
# Panic if anything mutates a shared informer cache
291291
- --env=ENABLE_CACHE_MUTATION_DETECTOR=true
292292
- --runtime-config=api/all=true
293-
- --test_args=--ginkgo.focus=\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|SidecarContainers|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking
293+
- --test_args=--ginkgo.focus=\[Feature:(AdmissionWebhookMatchConditions|InPlacePodVerticalScaling|StorageVersionAPI|PodPreset|StatefulSetAutoDeletePVC)\]|Networking
294294
--ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance|Example)\]|IPv6|csi-hostpath-v0
295295
--minStartupPods=8
296296
cluster: k8s-infra-prow-build

0 commit comments

Comments
 (0)