Skip to content

Commit 3275d09

Browse files
authored
Merge pull request #49443 from shurup/upgrade-kubecon-section-fix
Make the video section height on the main page flexible
2 parents c2da7e5 + ff7c22b commit 3275d09

File tree

3 files changed

+8
-20
lines changed

3 files changed

+8
-20
lines changed

assets/scss/_base.scss

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ $quickstart-button-padding: 0 50px;
1111
$vendor-strip-height: 88px;
1212
$vendor-strip-font-size: 16px;
1313

14-
// video
15-
$video-section-height: 200px;
16-
1714
@import "size";
1815
@import "documentation";
1916

@@ -256,9 +253,6 @@ $ocean-nodes-padding-Y: 60px;
256253
$ocean-nodes-main-margin-bottom: 60px;
257254
$ocean-nodes-h3-margin-bottom: 30px;
258255

259-
// video
260-
$video-section-height: 200px;
261-
262256
// Home-specific
263257

264258
.header-hero {
@@ -317,13 +311,10 @@ $video-section-height: 200px;
317311
}
318312

319313
// Video thingy
320-
#video {
321-
height: $video-section-height;
322-
}
323-
324314
#video {
325315
width: 100%;
326316
position: relative;
317+
overflow: hidden;
327318
background-position: center center;
328319
background-size: cover;
329320

@@ -426,6 +417,10 @@ $video-section-height: 200px;
426417
}
427418
}
428419

420+
#video:has(#desktopKCButton) {
421+
height: 580px;
422+
}
423+
429424
#videoPlayer {
430425
@include fullScreen;
431426
background-color: rgba(0, 0, 0, 0.9);

assets/scss/_desktop.scss

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
$main-max-width: 1200px;
22
$vendor-strip-height: 44px;
3-
$video-section-height: 580px;
43

54
@media screen and (min-width: 1024px) {
65

@@ -50,13 +49,12 @@ $video-section-height: 580px;
5049
}
5150

5251
#video {
53-
height: $video-section-height;
5452
position: relative;
55-
background-position: center center;
53+
background-position: top center;
5654
background-size: cover;
5755

5856
&>.light-text {
59-
margin-right: 10%;
57+
margin: 0 10% 15px 0;
6058
}
6159
}
6260

assets/scss/_tablet.scss

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ $headline-wrapper-margin-bottom: 40px;
77
$quickstart-button-padding: 0 50px;
88
$vendor-strip-font-size: 16px;
99

10-
//video
11-
$video-section-height: 400px;
12-
1310
////////////////////////////////////////////////////////////////////////////////////////////////////
1411
////////////////////////////////////////////////////////////////////////////////////////////////////
1512
////////////////////////////////////////////////////////////////////////////////////////////////////
@@ -113,15 +110,13 @@ $video-section-height: 400px;
113110
}
114111

115112
#video {
116-
height: $video-section-height;
117113
display: block;
118-
height: 550px;
119114

120115
& > .light-text {
121116
display: block;
122117
float: right;
123118
text-align: left;
124-
margin-right: 5%;
119+
margin: 0 5% 15px 0;
125120
}
126121
}
127122

0 commit comments

Comments
 (0)