Skip to content

Commit 378b0e5

Browse files
authored
Merge pull request #29915 from sftim/20211003_improve_recent_release_list
Improve recent release list
2 parents 6058c6f + 4dc0907 commit 378b0e5

File tree

3 files changed

+64
-22
lines changed

3 files changed

+64
-22
lines changed

assets/scss/_custom.scss

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,3 +765,24 @@ dl {
765765
margin-top: 1.5em;
766766
}
767767
}
768+
769+
.release-details {
770+
padding-left: 2em;
771+
772+
> :not(p) {
773+
font-size: 1.125em;
774+
}
775+
776+
.release-inline-heading, .release-inline-value {
777+
display: inline-block
778+
}
779+
780+
.release-inline-value {
781+
padding-left: 0.25em;
782+
}
783+
784+
p {
785+
margin-top: 1em;
786+
margin-bottom: 1em;
787+
}
788+
}

data/i18n/en/en.toml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,10 @@ other = "Read about"
189189
[main_read_more]
190190
other = "Read more"
191191

192+
[not_applicable]
193+
# Localization teams: it's OK to use a longer text here
194+
other = "n/a"
195+
192196
[note]
193197
other = "Note:"
194198

@@ -207,6 +211,12 @@ other = "Before you begin"
207211
[previous_patches]
208212
other = "Patch Releases:"
209213

214+
[release_date_after]
215+
other = ")"
216+
217+
[release_date_before]
218+
other = "(released: "
219+
210220
[seealso_heading]
211221
other = "See Also"
212222

layouts/shortcodes/release-data.html

Lines changed: 33 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,45 @@
11
{{ range $data := .Site.Data.releases.schedule.schedules }}
22
{{- $dataVersion := printf "%.2f" $data.release -}}
3-
<h2>{{ $dataVersion }}</h2>
4-
5-
<br>
3+
{{- $dataIdVersion := replace ( printf "%.2f" $data.release ) "." "-" | anchorize -}}
4+
<h3 id="release-v{{ $dataIdVersion }}">{{ $dataVersion }}</h3>
65

6+
<div class="release-details">
77
{{ if not $data.previousPatches }}
8-
<b>{{ T "latest_release" }}</b> {{ printf "%s.0" $dataVersion }}
9-
<br>
10-
<b>{{ T "end_of_life" }}</b> {{ printf "%s" $data.endOfLifeDate }}
11-
<br>
12-
<b>{{ T "previous_patches" }}</b> n/a
8+
<div>
9+
<b class="release-inline-heading">{{ T "latest_release" }}</b><span class="release-version release-inline-value">{{ printf "%s.0" $dataVersion }}</span>
10+
</div>
11+
<div>
12+
<b class="release-inline-heading">{{ T "end_of_life" }}</b><span class="release-eoldate release-inline-value">{{ printf "%s" $data.endOfLifeDate }}</span>
13+
</div>
14+
<div>
15+
<b class="release-inline-heading">{{ T "previous_patches" }}</b> <span class="notapplicable release-inline-value">{{ T "not_applicable" }}</span>
16+
</div>
1317
{{ end }}
1418

1519
{{ if $data.previousPatches }}
16-
<b>{{ T "latest_release" }}</b> {{ index $data.previousPatches 0 "release" }} (released: {{ index $data.previousPatches 0 "targetDate" }})
17-
<br>
18-
<b>{{ T "end_of_life" }}</b> {{ printf "%s" $data.endOfLifeDate }}
19-
<br>
20+
<div>
21+
<b class="release-inline-heading">{{ T "latest_release" }}</b><span class="release-inline-value">{{ index $data.previousPatches 0 "release" }} {{ T "release_date_before" }}{{ index $data.previousPatches 0 "targetDate" }}{{ T "release_date_after" }}</span>
22+
</div>
23+
<div>
24+
<b class="release-inline-heading">{{ T "end_of_life" }}</b><span class="release-eoldate release-inline-value">{{ printf "%s" $data.endOfLifeDate }}</span>
25+
</div>
26+
<div>
2027
<b>{{ T "previous_patches" }}</b>
21-
{{ range $previousPatchesList := $data.previousPatches }}
22-
{{range $previous_patches_key, $previous_patches_value := $previousPatchesList }}
23-
{{ if eq $previous_patches_key "release" }}<a href="https://git.k8s.io/kubernetes/CHANGELOG/CHANGELOG-{{ $dataVersion }}.md#v{{ replace $previous_patches_value `.` `` }}">{{ printf "%s" $previous_patches_value }}{{ T "inline_list_separator" }} </a>
24-
{{ end }}
25-
{{ end }}
26-
{{ end }}
27-
{{ end }}
28-
28+
<span class="release-prevpatches release-inline-value">
29+
{{- range $key, $value := sort $data.previousPatches ".targetDate" "asc" -}}
30+
{{ if $key }}{{ T "inline_list_separator" }}{{ end }}
31+
<a href="https://git.k8s.io/kubernetes/CHANGELOG/CHANGELOG-{{ $dataVersion }}.md#v{{ replace .release `.` `` }}">{{ printf "%s" .release }}</a>
32+
{{- end -}}
33+
{{- end -}}
34+
</span>
35+
</div>
2936

30-
<br>
31-
Complete {{ $dataVersion }} <a href="/releases/patch-releases/#{{ replace $dataVersion `.` `-` }}">Schedule</a> and <a href="https://git.k8s.io/kubernetes/CHANGELOG/CHANGELOG-{{ $dataVersion }}.md">Changelog</a>
37+
<!-- not yet localized, mark as English -->
38+
<p lang="en">
39+
Complete {{ $dataVersion }} <a href="/releases/patch-releases/#{{ replace $dataVersion `.` `-` }}">Schedule</a>
40+
and <a href="https://git.k8s.io/kubernetes/CHANGELOG/CHANGELOG-{{ $dataVersion }}.md">Changelog</a>
41+
</p>
3242

43+
</div>
3344

3445
{{ end }}

0 commit comments

Comments
 (0)