Skip to content

Commit 4534234

Browse files
authored
Merge pull request #30924 from sftim/20211214_improve_release_data_shortcode
Improve release data shortcode
2 parents 003ffe4 + 3fcc2c8 commit 4534234

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

data/i18n/en/en.toml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,11 @@ other = ")"
217217
[release_date_before]
218218
other = "(released: "
219219

220+
# See https://gohugo.io/functions/format/#gos-layout-string
221+
# Use a suitable format for your locale
222+
[release_date_format]
223+
other = "2006-01-02"
224+
220225
[seealso_heading]
221226
other = "See Also"
222227

layouts/shortcodes/release-data.html

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,22 @@ <h3 id="release-v{{ $dataIdVersion }}">{{ $dataVersion }}</h3>
55

66
<div class="release-details">
77
{{ if not $data.previousPatches }}
8+
<!-- initial minor release -->
89
<div>
9-
<b class="release-inline-heading">{{ T "latest_release" }}</b><span class="release-version release-inline-value">{{ printf "%s.0" $dataVersion }}</span>
10+
<b class="release-inline-heading">{{ T "latest_release" }}</b><span class="release-inline-value">{{ printf "%s.0" $dataVersion }}{{ if isset $data "releaseDate" }} {{ T "release_date_before" }}<time datetime="{{ time.Format "2006-01-02" $data.releaseDate }}">{{ time.Format ( T "release_date_format") $data.releaseDate }}</time>{{ T "release_date_after" }}{{- end -}}</span>
1011
</div>
1112
<div>
12-
<b class="release-inline-heading">{{ T "end_of_life" }}</b><span class="release-eoldate release-inline-value">{{ printf "%s" $data.endOfLifeDate }}</span>
13+
<b class="release-inline-heading">{{ T "end_of_life" }}</b><span class="release-eoldate release-inline-value"><time datetime="{{ time.Format "2006-01-02" $data.endOfLifeDate }}">{{ time.Format ( T "release_date_format") $data.endOfLifeDate }}</time></span>
1314
</div>
1415
<div>
1516
<b class="release-inline-heading">{{ T "previous_patches" }}</b> <span class="notapplicable release-inline-value">{{ T "not_applicable" }}</span>
1617
</div>
17-
{{ end }}
18-
19-
{{ if $data.previousPatches }}
18+
{{- else -}}
2019
<div>
21-
<b class="release-inline-heading">{{ T "latest_release" }}</b><span class="release-inline-value">{{ index $data.previousPatches 0 "release" }} {{ T "release_date_before" }}{{ index $data.previousPatches 0 "targetDate" }}{{ T "release_date_after" }}</span>
20+
<b class="release-inline-heading">{{ T "latest_release" }}</b><span class="release-inline-value">{{ index $data.previousPatches 0 "release" }} {{ T "release_date_before" }}<time datetime="{{ time.Format "2006-01-02" ( index $data.previousPatches 0 "targetDate" ) }}">{{ time.Format ( T "release_date_format") ( index $data.previousPatches 0 "targetDate" ) }}</time>{{ T "release_date_after" }}</span>
2221
</div>
2322
<div>
24-
<b class="release-inline-heading">{{ T "end_of_life" }}</b><span class="release-eoldate release-inline-value">{{ printf "%s" $data.endOfLifeDate }}</span>
23+
<b class="release-inline-heading">{{ T "end_of_life" }}</b><span class="release-eoldate release-inline-value"><time datetime="{{ time.Format "2006-01-02" $data.endOfLifeDate }}">{{ time.Format ( T "release_date_format") $data.endOfLifeDate }}</time></span>
2524
</div>
2625
<div>
2726
<b>{{ T "previous_patches" }}</b>
@@ -30,10 +29,10 @@ <h3 id="release-v{{ $dataIdVersion }}">{{ $dataVersion }}</h3>
3029
{{ if $key }}{{ T "inline_list_separator" }}{{ end }}
3130
<a href="https://git.k8s.io/kubernetes/CHANGELOG/CHANGELOG-{{ $dataVersion }}.md#v{{ replace .release `.` `` }}">{{ printf "%s" .release }}</a>
3231
{{- end -}}
33-
{{- end -}}
3432
</span>
3533
</div>
3634

35+
{{- end -}}
3736
<!-- not yet localized, mark as English -->
3837
<p lang="en">
3938
Complete {{ $dataVersion }} <a href="/releases/patch-releases/#{{ replace $dataVersion `.` `-` }}">Schedule</a>

0 commit comments

Comments
 (0)