You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Start with the smallest PRs (`size/XS`) first, and end with the largest (`size/XXL`). Review as many PRs as you can.
25
+
- Start with the smallest PRs (`size/XS`) first, and end with the largest (`size/XXL`).
26
+
Review as many PRs as you can.
26
27
- Make sure PR contributors sign the [CLA](https://github.com/kubernetes/community/blob/master/CLA.md).
27
-
- Use [this](https://github.com/zparnold/k8s-docs-pr-botherer) script to remind contributors
28
-
that haven't signed the CLA to do so.
28
+
- Use [this](https://github.com/zparnold/k8s-docs-pr-botherer) script to remind contributors
29
+
that haven't signed the CLA to do so.
29
30
- Provide feedback on changes and ask for technical reviews from members of other SIGs.
30
-
- Provide inline suggestions on the PR for the proposed content changes.
31
-
- If you need to verify content, comment on the PR and request more details.
32
-
- Assign relevant `sig/` label(s).
33
-
- If needed, assign reviewers from the `reviewers:` block in the file's front matter.
34
-
- You can also tag a [SIG](https://github.com/kubernetes/community/blob/master/sig-list.md)
35
-
for a review by commenting `@kubernetes/<sig>-pr-reviews` on the PR.
31
+
- Provide inline suggestions on the PR for the proposed content changes.
32
+
- If you need to verify content, comment on the PR and request more details.
33
+
- Assign relevant `sig/` label(s).
34
+
- If needed, assign reviewers from the `reviewers:` block in the file's front matter.
35
+
- You can also tag a [SIG](https://github.com/kubernetes/community/blob/master/sig-list.md)
36
+
for a review by commenting `@kubernetes/<sig>-pr-reviews` on the PR.
36
37
- Use the `/approve` comment to approve a PR for merging. Merge the PR when ready.
37
-
- PRs should have a `/lgtm` comment from another member before merging.
38
-
- Consider accepting technically accurate content that doesn't meet the
39
-
[style guidelines](/docs/contribute/style/style-guide/). As you approve the change,
40
-
open a new issue to address the style concern. You can usually write these style fix
41
-
issues as [good first issues](https://kubernetes.dev/docs/guide/help-wanted/#good-first-issue).
42
-
- Using style fixups as good first issues is a good way to ensure a supply of easier tasks
43
-
to help onboard new contributors.
44
-
- Also check for pull requests against the [reference docs generator](https://github.com/kubernetes-sigs/reference-docs) code, and review those (or bring in help).
38
+
- PRs should have a `/lgtm` comment from another member before merging.
39
+
- Consider accepting technically accurate content that doesn't meet the
40
+
[style guidelines](/docs/contribute/style/style-guide/). As you approve the change,
41
+
open a new issue to address the style concern. You can usually write these style fix
42
+
issues as [good first issues](https://kubernetes.dev/docs/guide/help-wanted/#good-first-issue).
43
+
- Using style fixups as good first issues is a good way to ensure a supply of easier tasks
44
+
to help onboard new contributors.
45
+
- Also check for pull requests against the [reference docs generator](https://github.com/kubernetes-sigs/reference-docs)
46
+
code, and review those (or bring in help).
45
47
- Support the [issue wrangler](/docs/contribute/participate/issue-wrangler/) to
46
48
triage and tag incoming issues daily.
47
49
See [Triage and categorize issues](/docs/contribute/review/for-approvers/#triage-and-categorize-issues)
48
50
for guidelines on how SIG Docs uses metadata.
49
51
50
52
{{< note >}}
51
-
PR wrangler duties do not apply to localization PRs (non-English PRs).
52
-
Localization teams have their own processes and teams for reviewing their language PRs.
53
-
However, it's often helpful to ensure language PRs are labeled correctly,
54
-
review small non-language dependent PRs (like a link update),
55
-
or tag reviewers or contributors in long-running PRs (ones opened more than 6 months ago and have not been updated in a month or more).
53
+
PR wrangler duties do not apply to localization PRs (non-English PRs).
54
+
Localization teams have their own processes and teams for reviewing their language PRs.
55
+
However, it's often helpful to ensure language PRs are labeled correctly,
56
+
review small non-language dependent PRs (like a link update),
57
+
or tag reviewers or contributors in long-running PRs
58
+
(ones opened more than 6 months ago and have not been updated in a month or more).
56
59
{{< /note >}}
57
60
58
-
59
61
### Helpful GitHub queries for wranglers
60
62
61
63
The following queries are helpful when wrangling.
@@ -99,10 +101,11 @@ These queries exclude localization PRs. All queries are against the main branch
99
101
Reviews and approvals are one tool to keep our PR queue short and current. Another tool is closure.
100
102
101
103
Close PRs where:
104
+
102
105
- The author hasn't signed the CLA for two weeks.
103
106
104
-
Authors can reopen the PR after signing the CLA. This is a low-risk way to make
105
-
sure nothing gets merged without a signed CLA.
107
+
Authors can reopen the PR after signing the CLA. This is a low-risk way to make
108
+
sure nothing gets merged without a signed CLA.
106
109
107
110
- The author has not responded to comments or feedback in 2 or more weeks.
108
111
@@ -112,11 +115,9 @@ Often a closure notice is what spurs an author to resume and finish their contri
112
115
To close a pull request, leave a `/close` comment on the PR.
113
116
114
117
{{< note >}}
115
-
116
118
The [`k8s-triage-robot`](https://github.com/k8s-triage-robot) bot marks issues
117
119
as stale after 90 days of inactivity. After 30 more days it marks issues as rotten
118
120
and closes them. PR wranglers should close issues after 14-30 days of inactivity.
Copy file name to clipboardExpand all lines: content/en/docs/doc-contributor-tools/linkchecker/README.md
+30-15Lines changed: 30 additions & 15 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,39 +1,52 @@
1
1
# Internal link checking tool
2
2
3
-
You can use [htmltest](https://github.com/wjdp/htmltest) to check for broken links in [`/content/en/`](https://git.k8s.io/website/content/en/). This is useful when refactoring sections of content, moving pages around, or renaming files or page headers.
3
+
You can use [htmltest](https://github.com/wjdp/htmltest) to check for broken links in
4
+
[`/content/en/`](https://git.k8s.io/website/content/en/). This is useful when refactoring
5
+
sections of content, moving pages around, or renaming files or page headers.
4
6
5
7
## How the tool works
6
8
7
-
`htmltest` scans links in the generated HTML files of the kubernetes website repository. It runs using a `make` command which does the following:
9
+
`htmltest` scans links in the generated HTML files of the kubernetes website repository.
10
+
It runs using a `make` command which does the following:
8
11
9
-
- Builds the site and generates output HTML in the `/public` directory of your local `kubernetes/website` repository
12
+
- Builds the site and generates output HTML in the `/public` directory of your
13
+
local `kubernetes/website` repository
10
14
- Pulls the `wdjp/htmltest` Docker image
11
15
- Mounts your local `kubernetes/website` repository to the Docker image
12
-
- Scans the files generated in the `/public` directory and provides command line output when it encounters broken internal links
16
+
- Scans the files generated in the `/public` directory and provides command line
17
+
output when it encounters broken internal links
13
18
14
19
## What it does and doesn't check
15
20
16
-
The link checker scans generated HTML files, not raw Markdown. The htmltest tool depends on a configuration file, [`.htmltest.yml`](https://git.k8s.io/website/.htmltest.yml), to determine which content to examine.
21
+
The link checker scans generated HTML files, not raw Markdown.
22
+
The htmltest tool depends on a configuration file,
- Empty hashes (`<a href="#">` or `[title](#)`) and empty hrefs (`<a href="">` or `[title]()`)
24
34
- Internal links to images and other media files
25
35
26
36
The link checker does not scan the following:
27
37
28
-
- Links included in the top and side nav bars, footer links, or links in a page's `<head>` section, such as links to CSS stylesheets, scripts, and meta information
38
+
- Links included in the top and side nav bars, footer links, or links in a page's `<head>` section,
39
+
such as links to CSS stylesheets, scripts, and meta information
29
40
- Top level pages and their children, for example: `/training`, `/community`, `/case-studies/adidas`
30
41
- Blog posts
31
-
- API Reference documentation, for example: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/
0 commit comments