Skip to content

Commit 5f49d6b

Browse files
authored
Merge pull request #48149 from windsonsea/linkch
Tweak and clean up pr-wranglers and linkchecke readme
2 parents e313136 + 99d420a commit 5f49d6b

File tree

2 files changed

+58
-42
lines changed

2 files changed

+58
-42
lines changed

content/en/docs/contribute/participate/pr-wranglers.md

Lines changed: 28 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -22,40 +22,42 @@ Each day in a week-long shift as PR Wrangler:
2222
- Review [open pull requests](https://github.com/kubernetes/website/pulls) for quality
2323
and adherence to the [Style](/docs/contribute/style/style-guide/) and
2424
[Content](/docs/contribute/style/content-guide/) guides.
25-
- Start with the smallest PRs (`size/XS`) first, and end with the largest (`size/XXL`). Review as many PRs as you can.
25+
- Start with the smallest PRs (`size/XS`) first, and end with the largest (`size/XXL`).
26+
Review as many PRs as you can.
2627
- Make sure PR contributors sign the [CLA](https://github.com/kubernetes/community/blob/master/CLA.md).
27-
- Use [this](https://github.com/zparnold/k8s-docs-pr-botherer) script to remind contributors
28-
that haven't signed the CLA to do so.
28+
- Use [this](https://github.com/zparnold/k8s-docs-pr-botherer) script to remind contributors
29+
that haven't signed the CLA to do so.
2930
- Provide feedback on changes and ask for technical reviews from members of other SIGs.
30-
- Provide inline suggestions on the PR for the proposed content changes.
31-
- If you need to verify content, comment on the PR and request more details.
32-
- Assign relevant `sig/` label(s).
33-
- If needed, assign reviewers from the `reviewers:` block in the file's front matter.
34-
- You can also tag a [SIG](https://github.com/kubernetes/community/blob/master/sig-list.md)
35-
for a review by commenting `@kubernetes/<sig>-pr-reviews` on the PR.
31+
- Provide inline suggestions on the PR for the proposed content changes.
32+
- If you need to verify content, comment on the PR and request more details.
33+
- Assign relevant `sig/` label(s).
34+
- If needed, assign reviewers from the `reviewers:` block in the file's front matter.
35+
- You can also tag a [SIG](https://github.com/kubernetes/community/blob/master/sig-list.md)
36+
for a review by commenting `@kubernetes/<sig>-pr-reviews` on the PR.
3637
- Use the `/approve` comment to approve a PR for merging. Merge the PR when ready.
37-
- PRs should have a `/lgtm` comment from another member before merging.
38-
- Consider accepting technically accurate content that doesn't meet the
39-
[style guidelines](/docs/contribute/style/style-guide/). As you approve the change,
40-
open a new issue to address the style concern. You can usually write these style fix
41-
issues as [good first issues](https://kubernetes.dev/docs/guide/help-wanted/#good-first-issue).
42-
- Using style fixups as good first issues is a good way to ensure a supply of easier tasks
43-
to help onboard new contributors.
44-
- Also check for pull requests against the [reference docs generator](https://github.com/kubernetes-sigs/reference-docs) code, and review those (or bring in help).
38+
- PRs should have a `/lgtm` comment from another member before merging.
39+
- Consider accepting technically accurate content that doesn't meet the
40+
[style guidelines](/docs/contribute/style/style-guide/). As you approve the change,
41+
open a new issue to address the style concern. You can usually write these style fix
42+
issues as [good first issues](https://kubernetes.dev/docs/guide/help-wanted/#good-first-issue).
43+
- Using style fixups as good first issues is a good way to ensure a supply of easier tasks
44+
to help onboard new contributors.
45+
- Also check for pull requests against the [reference docs generator](https://github.com/kubernetes-sigs/reference-docs)
46+
code, and review those (or bring in help).
4547
- Support the [issue wrangler](/docs/contribute/participate/issue-wrangler/) to
4648
triage and tag incoming issues daily.
4749
See [Triage and categorize issues](/docs/contribute/review/for-approvers/#triage-and-categorize-issues)
4850
for guidelines on how SIG Docs uses metadata.
4951

5052
{{< note >}}
51-
PR wrangler duties do not apply to localization PRs (non-English PRs).
52-
Localization teams have their own processes and teams for reviewing their language PRs.
53-
However, it's often helpful to ensure language PRs are labeled correctly,
54-
review small non-language dependent PRs (like a link update),
55-
or tag reviewers or contributors in long-running PRs (ones opened more than 6 months ago and have not been updated in a month or more).
53+
PR wrangler duties do not apply to localization PRs (non-English PRs).
54+
Localization teams have their own processes and teams for reviewing their language PRs.
55+
However, it's often helpful to ensure language PRs are labeled correctly,
56+
review small non-language dependent PRs (like a link update),
57+
or tag reviewers or contributors in long-running PRs
58+
(ones opened more than 6 months ago and have not been updated in a month or more).
5659
{{< /note >}}
5760

58-
5961
### Helpful GitHub queries for wranglers
6062

6163
The following queries are helpful when wrangling.
@@ -99,10 +101,11 @@ These queries exclude localization PRs. All queries are against the main branch
99101
Reviews and approvals are one tool to keep our PR queue short and current. Another tool is closure.
100102

101103
Close PRs where:
104+
102105
- The author hasn't signed the CLA for two weeks.
103106

104-
Authors can reopen the PR after signing the CLA. This is a low-risk way to make
105-
sure nothing gets merged without a signed CLA.
107+
Authors can reopen the PR after signing the CLA. This is a low-risk way to make
108+
sure nothing gets merged without a signed CLA.
106109

107110
- The author has not responded to comments or feedback in 2 or more weeks.
108111

@@ -112,11 +115,9 @@ Often a closure notice is what spurs an author to resume and finish their contri
112115
To close a pull request, leave a `/close` comment on the PR.
113116

114117
{{< note >}}
115-
116118
The [`k8s-triage-robot`](https://github.com/k8s-triage-robot) bot marks issues
117119
as stale after 90 days of inactivity. After 30 more days it marks issues as rotten
118120
and closes them. PR wranglers should close issues after 14-30 days of inactivity.
119-
120121
{{< /note >}}
121122

122123
## PR Wrangler shadow program

content/en/docs/doc-contributor-tools/linkchecker/README.md

Lines changed: 30 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,52 @@
11
# Internal link checking tool
22

3-
You can use [htmltest](https://github.com/wjdp/htmltest) to check for broken links in [`/content/en/`](https://git.k8s.io/website/content/en/). This is useful when refactoring sections of content, moving pages around, or renaming files or page headers.
3+
You can use [htmltest](https://github.com/wjdp/htmltest) to check for broken links in
4+
[`/content/en/`](https://git.k8s.io/website/content/en/). This is useful when refactoring
5+
sections of content, moving pages around, or renaming files or page headers.
46

57
## How the tool works
68

7-
`htmltest` scans links in the generated HTML files of the kubernetes website repository. It runs using a `make` command which does the following:
9+
`htmltest` scans links in the generated HTML files of the kubernetes website repository.
10+
It runs using a `make` command which does the following:
811

9-
- Builds the site and generates output HTML in the `/public` directory of your local `kubernetes/website` repository
12+
- Builds the site and generates output HTML in the `/public` directory of your
13+
local `kubernetes/website` repository
1014
- Pulls the `wdjp/htmltest` Docker image
1115
- Mounts your local `kubernetes/website` repository to the Docker image
12-
- Scans the files generated in the `/public` directory and provides command line output when it encounters broken internal links
16+
- Scans the files generated in the `/public` directory and provides command line
17+
output when it encounters broken internal links
1318

1419
## What it does and doesn't check
1520

16-
The link checker scans generated HTML files, not raw Markdown. The htmltest tool depends on a configuration file, [`.htmltest.yml`](https://git.k8s.io/website/.htmltest.yml), to determine which content to examine.
21+
The link checker scans generated HTML files, not raw Markdown.
22+
The htmltest tool depends on a configuration file,
23+
[`.htmltest.yml`](https://git.k8s.io/website/.htmltest.yml),
24+
to determine which content to examine.
1725

1826
The link checker scans the following:
1927

20-
- All content generated from Markdown in [`/content/en/docs`](https://git.k8s.io/website/content/en/docs/) directory, excluding:
21-
- Generated API references, for example https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/
28+
- All content generated from Markdown in
29+
[`/content/en/docs`](https://git.k8s.io/website/content/en/docs/) directory, excluding:
30+
- Generated API references, for example
31+
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/
2232
- All internal links, excluding:
2333
- Empty hashes (`<a href="#">` or `[title](#)`) and empty hrefs (`<a href="">` or `[title]()`)
2434
- Internal links to images and other media files
2535

2636
The link checker does not scan the following:
2737

28-
- Links included in the top and side nav bars, footer links, or links in a page's `<head>` section, such as links to CSS stylesheets, scripts, and meta information
38+
- Links included in the top and side nav bars, footer links, or links in a page's `<head>` section,
39+
such as links to CSS stylesheets, scripts, and meta information
2940
- Top level pages and their children, for example: `/training`, `/community`, `/case-studies/adidas`
3041
- Blog posts
31-
- API Reference documentation, for example: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/
42+
- API Reference documentation, for example
43+
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/
3244
- Localizations
3345

3446
## Prerequisites and installation
3547

3648
You must install
49+
3750
* [Docker](https://docs.docker.com/get-docker/)
3851
* [make](https://www.gnu.org/software/make/)
3952

@@ -45,9 +58,9 @@ To run the link checker:
4558

4659
2. Run the following command:
4760

48-
```
49-
make container-internal-linkcheck
50-
```
61+
```shell
62+
make container-internal-linkcheck
63+
```
5164

5265
## Understanding the output
5366

@@ -70,7 +83,9 @@ The target URL is `#preserving-unknown-fields`.
7083
One way to fix this is to:
7184

7285
1. Navigate to the Markdown file with a broken link.
73-
2. Using a text editor, do a full-text search (usually Ctrl+F or Command+F) for the broken link's URL, `#preserving-unknown-fields`.
74-
3. Fix the link. For a broken page hash (or _anchor_) link, check whether the topic was renamed or removed.
86+
1. Using a text editor, do a full-text search (usually Ctrl+F or Command+F) for the
87+
broken link's URL, `#preserving-unknown-fields`.
88+
1. Fix the link. For a broken page hash (or _anchor_) link,
89+
check whether the topic was renamed or removed.
7590

76-
Run htmltest to verify that broken links are fixed.
91+
Run htmltest to verify that broken links are fixed.

0 commit comments

Comments
 (0)