Skip to content

Commit 691f866

Browse files
authored
Clarify node affinity in ScheduleDaemonSetPods
> If node affinity of the DaemonSet pod already exists, it is replaced. The original statement made it sound like the original node affinity was ignored when selecting the target node. Added clarification it is not the case. For reference, the DaemonSet controller behavior. https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/daemon_controller.go#L1194
1 parent 2139b50 commit 691f866

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

content/en/docs/concepts/workloads/controllers/daemonset.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ That introduces the following issues:
125125
scheduler instead of the DaemonSet controller, by adding the `NodeAffinity` term
126126
to the DaemonSet pods, instead of the `.spec.nodeName` term. The default
127127
scheduler is then used to bind the pod to the target host. If node affinity of
128-
the DaemonSet pod already exists, it is replaced. The DaemonSet controller only
128+
the DaemonSet pod already exists, it is replaced (the original node affinity was taken into account before selecting the target host). The DaemonSet controller only
129129
performs these operations when creating or modifying DaemonSet pods, and no
130130
changes are made to the `spec.template` of the DaemonSet.
131131

0 commit comments

Comments
 (0)