Skip to content

Commit 6b1afc2

Browse files
committed
Review remarks
1 parent 8f6b617 commit 6b1afc2

File tree

1 file changed

+7
-7
lines changed
  • content/en/docs/concepts/workloads/controllers

1 file changed

+7
-7
lines changed

content/en/docs/concepts/workloads/controllers/job.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,20 +1011,20 @@ status:
10111011
{{< feature-state for_k8s_version="v1.30" state="alpha" >}}
10121012
10131013
{{< note >}}
1014-
You can only set `ManagedBy` field on Jobs if you enable the `JobManagedBy`
1014+
You can only set the `managedBy` field on Jobs if you enable the `JobManagedBy`
10151015
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/)
10161016
(disabled by default).
10171017
{{< /note >}}
10181018

10191019
This feature allows you to disable the built-in Job controller, for a specific
10201020
Job, and delegate reconciliation of the Job to an external controller.
10211021

1022-
By setting a custom value of the `spec.managedBy` field - any value
1023-
other than `kubernetes.io/job-controller` - you indicate the controller which
1024-
reconciles the Job. The value of the field is immutable.
1022+
You indicate the controller that reconciles the Job by setting a custom value
1023+
for the `spec.managedBy` field - any value
1024+
other than `kubernetes.io/job-controller`. The value of the field is immutable.
10251025

10261026
{{< note >}}
1027-
When using this feature make sure the controller indicated by the field is
1027+
When using this feature, make sure the controller indicated by the field is
10281028
installed, otherwise the Job may not be reconciled at all.
10291029
{{< /note >}}
10301030

@@ -1043,8 +1043,8 @@ Finally, when developing an external Job controller make sure it does not use th
10431043

10441044
{{< warning >}}
10451045
If you are considering to disable the `JobManagedBy` feature gate, or to
1046-
downgrade the cluster to a version without the feature gate enabled, inspect
1047-
there are no jobs with a custom value of the `spec.managedBy` field. If there
1046+
downgrade the cluster to a version without the feature gate enabled, check if
1047+
there are jobs with a custom value of the `spec.managedBy` field. If there
10481048
are such jobs, there is a risk that they might be reconciled by two controllers
10491049
after the operation: the built-in Job controller and the external controller
10501050
indicated by the field value.

0 commit comments

Comments
 (0)