Skip to content

Commit 92c9ae4

Browse files
Apply suggestions from code review
Co-authored-by: Marcelo Giles <[email protected]> Signed-off-by: Sascha Grunert <[email protected]>
1 parent 7949cf3 commit 92c9ae4

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
flowchart TD
22
A(Create Policy\ninstance) -->|annotate namespace\nto validate signatures| B(Create Pod)
3-
B --> C[policy evaluation]
4-
C --> D[fa:fa-check Admitted]
5-
C --> E[fa:fa-xmark Not admitted]
3+
B --> C{policy evaluation}
4+
C --> |pass| D[fa:fa-check Admitted]
5+
C --> |fail| E[fa:fa-xmark Not admitted]
66
D --> |if necessary| F[Image Pull]
23.9 KB
Loading

content/en/blog/_posts/2023-06-29-container-image-signature-verification/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,9 @@ for it:
171171
FATA[…] pulling image: rpc error: code = Unknown desc = SignatureValidationFailed: Source image rejected: A signature was required, but no signature exists
172172
```
173173

174-
It's important to mention that CRI-O will match the
174+
It is important to mention that CRI-O will match the
175175
`.critical.identity.docker-reference` field within the signature to match with
176-
the image repository. For example, if I verify the image
176+
the image repository. For example, if you verify the image
177177
`registry.k8s.io/kube-apiserver-amd64:v1.28.0-alpha.3`, then the corresponding
178178
`docker-reference` should be `registry.k8s.io/kube-apiserver-amd64`:
179179

@@ -204,7 +204,7 @@ asia-northeast2-docker.pkg.dev/k8s-artifacts-prod/images/kubernetes/kube-apiserv
204204
```
205205

206206
The change of the `docker-reference` to `registry.k8s.io` makes it easier for
207-
end users to validate the signatures, because the cannot know anything about the
207+
end users to validate the signatures, because they cannot know anything about the
208208
underlying infrastructure being used. The feature to set the identity on image
209209
signing has been added to [cosign][cosign-pr] via the flag `sign
210210
--sign-container-identity` as well and will be part of its upcoming release.
86 KB
Loading

0 commit comments

Comments
 (0)