Skip to content

Commit 96e4198

Browse files
committed
Fix: use correct metric allow list manifest format
According to https://github.com/kubernetes/kubernetes/blob/c15581b277e9e42d830898357fdbd92dcf7981c6/staging/src/k8s.io/component-base/metrics/opts.go#L365 , the manifest content should be a map.
1 parent 257cd68 commit 96e4198

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

content/en/docs/concepts/cluster-administration/system-metrics.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ disabled metrics (i.e. `--disabled-metrics=metric1,metric2`).
183183
## Metric cardinality enforcement
184184

185185
Metrics with unbounded dimensions could cause memory issues in the components they instrument. To
186-
limit resource use, you can use the `--allow-label-value` command line option to dynamically
186+
limit resource use, you can use the `--allow-metric-labels` command line option to dynamically
187187
configure an allow-list of label values for a metric.
188188

189189
In alpha stage, the flag can only take in a series of mappings as metric label allow-list.
@@ -207,9 +207,8 @@ can specify the path to that configuration file using the `--allow-metric-labels
207207
line argument to a component. Here's an example of the contents of that configuration file:
208208

209209
```yaml
210-
allow-list:
211-
- "metric1,label2": "v1,v2,v3"
212-
- "metric2,label1": "v1,v2,v3"
210+
"metric1,label2": "v1,v2,v3"
211+
"metric2,label1": "v1,v2,v3"
213212
```
214213
215214
Additionally, the `cardinality_enforcement_unexpected_categorizations_total` meta-metric records the

0 commit comments

Comments
 (0)