Skip to content

Commit b1479aa

Browse files
authored
Merge pull request #42206 from sftim/20230725_update_owners
Switch to finer controls on approver access
2 parents 2c434ac + 7f680c9 commit b1479aa

File tree

26 files changed

+220
-12
lines changed

26 files changed

+220
-12
lines changed

.github/OWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# See the OWNERS docs at https://go.k8s.io/owners
22

33
reviewers:
4-
- sig-docs-en-reviews # Defined in OWNERS_ALIASES
4+
- sig-docs-website-owners # Defined in OWNERS_ALIASES
55

66
approvers:
7-
- sig-docs-en-owners # Defined in OWNERS_ALIASES
7+
- sig-docs-website-owners # Defined in OWNERS_ALIASES

OWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# See the OWNERS docs at https://go.k8s.io/owners
22

33
reviewers:
4-
- sig-docs-en-reviews # Defined in OWNERS_ALIASES
4+
- sig-docs-website-owners # Defined in OWNERS_ALIASES
55

66
approvers:
7-
- sig-docs-en-owners # Defined in OWNERS_ALIASES
7+
- sig-docs-website-owners # Defined in OWNERS_ALIASES
88

99
emeritus_approvers:
1010
# - chenopis, commented out to disable PR assignments

OWNERS_ALIASES

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,28 @@ aliases:
88
- mrbobbytables
99
- nate-double-u
1010
- sftim
11+
sig-docs-website-owners: # Admins for overall website
12+
- divya-mohan0209
13+
- natalisucks
14+
- reylejano
15+
- sftim
16+
- tengqm
17+
- drewhagen # RT 1.30 Docs Lead
18+
- katcosgrove # RT 1.30 Lead
1119
sig-docs-localization-owners: # Admins for localization content
1220
- a-mccarthy
1321
- divya-mohan0209
1422
- natalisucks
23+
- nate-double-u
24+
- reylejano
25+
- sftim
26+
- seokho-son
27+
- tengqm
28+
sig-docs-localization-reviewers: # PR reviews for localization changes
29+
- a-mccarthy
30+
- divya-mohan0209
31+
- natalisucks
32+
- nate-double-u
1533
- reylejano
1634
- sftim
1735
- seokho-son
@@ -26,8 +44,6 @@ aliases:
2644
- celestehorgan
2745
- dipesh-rawat
2846
- divya-mohan0209
29-
- drewhagen # RT 1.30 Docs Lead
30-
- katcosgrove # RT 1.30 Lead
3147
- natalisucks
3248
- nate-double-u
3349
- reylejano

assets/OWNERS

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# Label certain changes as web development
2+
3+
filters:
4+
"\\.js":
5+
labels:
6+
- area/web-development
7+
"\\.scss$":
8+
labels:
9+
- area/web-development

assets/images/OWNERS

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# See the OWNERS docs at https://go.k8s.io/owners
2+
3+
# This is the directory for common images. Allow English localization
4+
# reviewers to review and approve.
5+
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
6+
7+
reviewers:
8+
- sig-docs-en-reviews
9+
10+
approvers:
11+
- sig-docs-en-owners
12+
13+
filters:
14+
"\\.svg":
15+
labels:
16+
- area/web-development
17+
"\\.png$":
18+
labels:
19+
- area/web-development
20+
"\\.jpe?g$":
21+
labels:
22+
- area/web-development

content/OWNERS

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# See the OWNERS docs at https://go.k8s.io/owners
2+
3+
# This is the directory for all source content.
4+
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
5+
6+
reviewers:
7+
- sig-docs-localization-reviewers
8+
9+
approvers:
10+
- sig-docs-localization-owners
11+
- sig-docs-website-owners

content/de/OWNERS

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ reviewers:
88

99
approvers:
1010
- sig-docs-de-owners
11+
- sig-docs-website-owners # important due to no_parent_owners option
1112

1213
labels:
14+
- area/localization
1315
- language/de
16+
17+
# Disable inheritance so that the localization team don't end up as approvers for all
18+
# languages.
19+
# https://github.com/kubernetes/community/blob/master/communication/website-guidelines.md
20+
options:
21+
no_parent_owners: true

content/es/OWNERS

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ reviewers:
88

99
approvers:
1010
- sig-docs-es-owners
11+
- sig-docs-website-owners # important due to no_parent_owners option
1112

1213
labels:
14+
- area/localization
1315
- language/es
16+
17+
# Disable inheritance so that the localization team don't end up as approvers for all
18+
# languages.
19+
# https://github.com/kubernetes/community/blob/master/communication/website-guidelines.md
20+
options:
21+
no_parent_owners: true

content/fr/OWNERS

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,15 @@ reviewers:
88

99
approvers:
1010
- sig-docs-fr-owners
11+
- sig-docs-website-owners # important due to no_parent_owners option
1112

1213
labels:
14+
- area/localization
1315
- language/fr
16+
17+
# Disable inheritance so that the localization team don't end up as approvers for all
18+
# languages.
19+
# https://github.com/kubernetes/community/blob/master/communication/website-guidelines.md
20+
options:
21+
no_parent_owners: true
22+

content/hi/OWNERS

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@ reviewers:
88

99
approvers:
1010
- sig-docs-hi-owners
11+
- sig-docs-website-owners # important due to no_parent_owners option
1112

1213
labels:
14+
- area/localization
1315
- language/hi
16+
17+
# Disable inheritance so that the localization team don't end up as approvers for all
18+
# languages.
19+
# https://github.com/kubernetes/community/blob/master/communication/website-guidelines.md
20+
options:
21+
no_parent_owners: true

0 commit comments

Comments
 (0)