Skip to content

Commit b4b8893

Browse files
committed
Fix default value for MaxSurge
The implementation defines the default value for MaxSurge being 0, as to preserve the current behavior of rolling updates in DaemonSets. This change is just a copy-paste of the docblock defined in the types.go file. See: - https://github.com/kubernetes/kubernetes/blob/10a3cc815bea73f78f7126cab5df95233da96e1b/pkg/apis/apps/types.go - https://github.com/kubernetes/kubernetes/blob/10a3cc815bea73f78f7126cab5df95233da96e1b/pkg/apis/apps/v1/defaults.go#L87-L91
1 parent 007f515 commit b4b8893

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

content/en/docs/tasks/manage-daemon/update-daemon-set.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ You may want to set
4040
[`.spec.minReadySeconds`](/docs/concepts/workloads/controllers/deployment/#min-ready-seconds)
4141
(default to 0) and
4242
[`.spec.maxSurge`](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#max-surge)
43-
(a beta feature and defaults to 25%) as well.
43+
(a beta feature and defaults to 0) as well.
4444

4545
### Creating a DaemonSet with `RollingUpdate` update strategy
4646

content/ko/docs/tasks/manage-daemon/update-daemon-set.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ weight: 10
3939
[`.spec.minReadySeconds`](/ko/docs/concepts/workloads/controllers/deployment/#최소-대기-시간초)
4040
(기본값은 0),
4141
[`.spec.maxSurge`](/ko/docs/concepts/workloads/controllers/deployment/#최대-서지-max-surge)
42-
(베타 기능, 기본값은 25%)를
42+
(베타 기능, 기본값은 0)를
4343
설정할 수도 있다.
4444

4545
### `RollingUpdate` 업데이트 전략으로 데몬셋 생성

content/zh/docs/tasks/manage-daemon/update-daemon-set.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,12 @@ You may want to set
6767
[`.spec.minReadySeconds`](/docs/concepts/workloads/controllers/deployment/#min-ready-seconds)
6868
(default to 0) and
6969
[`.spec.maxSurge`](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#max-surge)
70-
(a beta feature and defaults to 25%) as well.
70+
(a beta feature and defaults to 0) as well.
7171
-->
7272
你可能想设置
7373
[`.spec.updateStrategy.rollingUpdate.maxUnavailable`](/zh/docs/concepts/workloads/controllers/deployment/#max-unavailable) (默认为 1),
7474
[`.spec.minReadySeconds`](/zh/docs/concepts/workloads/controllers/deployment/#min-ready-seconds) (默认为 0) 和
75-
[`.spec.maxSurge`](/zh/docs/concepts/workloads/controllers/deployment/#max-surge) (一种 Beta 阶段的特性,默认为 25%)
75+
[`.spec.maxSurge`](/zh/docs/concepts/workloads/controllers/deployment/#max-surge) (一种 Beta 阶段的特性,默认为 0)
7676

7777
<!--
7878
### Creating a DaemonSet with `RollingUpdate` update strategy

0 commit comments

Comments
 (0)