Skip to content

Commit ce1491d

Browse files
jsturtevantmarossettengqmaravindhp
authored
Apply suggestions from code review
Co-authored-by: Mark Rossetti <[email protected]> Co-authored-by: Qiming Teng <[email protected]> Co-authored-by: Aravindh Puthiyaparambil <[email protected]>
1 parent e2cccab commit ce1491d

File tree

4 files changed

+20
-15
lines changed

4 files changed

+20
-15
lines changed

content/en/docs/reference/command-line-tools-reference/feature-gates/windows-cpu-and-memory-affinity.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,7 @@ stages:
1212
defaultValue: false
1313
fromVersion: "1.32"
1414
---
15-
Add CPU and Memory Affinity support to Windows nodes with [CPUManager](/docs/tasks/administer-cluster/cpu-management-policies#windows-support), [MemoryManager](/docs/tasks/administer-cluster/memory-manager.md#windows-support) and Topology manager.
15+
16+
Add CPU and Memory Affinity support to Windows nodes with [CPUManager](/docs/tasks/administer-cluster/cpu-management-policies/#windows-support),
17+
[MemoryManager](/docs/tasks/administer-cluster/memory-manager/#windows-support)
18+
and topology manager.

content/en/docs/tasks/administer-cluster/cpu-management-policies.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ management policies to determine some placement preferences on the node.
5151

5252
## Windows Support
5353

54-
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
54+
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
5555

56-
The CPU Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature flag and requires a support in the container runtime.
57-
Once feature is enabled follow the steps above to configure the [CPU Manager Policy](#configuration).
56+
The CPU Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature gate and requires a support in the container runtime.
57+
Once the feature gate is enabled, follow the steps below to configure the [CPU manager policy](#configuration).
5858

5959
### Configuration
6060

content/en/docs/tasks/administer-cluster/memory-manager.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Preceding v1.22, the `kubelet` must be started with the following flag:
4646

4747
in order to enable the Memory Manager feature.
4848

49-
## How does the Memory Manager Operates?
49+
## How does the Memory Manager Operate?
5050

5151
The Memory Manager currently offers the guaranteed memory (and hugepages) allocation
5252
for Pods in Guaranteed QoS class.
@@ -93,9 +93,10 @@ illustrates how the management of groups occurs.
9393

9494
### Windows Support
9595

96-
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
96+
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
9797

98-
Windows support can be enabled via the `WindowsCPUAndMemoryAffinity` feature gate and requires a support in the container runtime. Only the [BestEffort Policy](#policy-best-effort) is supported on Windows.
98+
Windows support can be enabled via the `WindowsCPUAndMemoryAffinity` feature gate and requires a support in the container runtime.
99+
Only the [BestEffort Policy](#policy-best-effort) is supported on Windows.
99100

100101
## Memory Manager configuration
101102

@@ -130,17 +131,17 @@ In the case of the `BestEffort` or `Burstable` pod, the `Static` Memory Manager
130131
the default topology hint as there is no request for the guaranteed memory,
131132
and does not reserve the memory in the internal [NodeMap][2] object.
132133

133-
This policy is only Supported on Linux.
134+
This policy is only supported on Linux.
134135

135136
#### BestEffort policy {#policy-best-effort}
136137

137-
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
138+
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
138139

139-
This policy is only Support on Windows.
140+
This policy is only supported on Windows.
140141

141-
On Windows, NUMA node assignment works differently than Linux. There is no mechanism
142-
to ensure that Memory access only comes from a specific NUMA node, instead the Windows
143-
internals will select the most optimal NUMA node based on the CPU assignment and it is
142+
On Windows, NUMA node assignment works differently from Linux. There is no mechanism
143+
to ensure that memory access only comes from a specific NUMA node, instead the Windows
144+
scheduler will select the most optimal NUMA node based on the CPU assignments and it is
144145
possible that Windows might use other nodes if required or deemed optimal. For this
145146
reason this policy is best effort.
146147

content/en/docs/tasks/administer-cluster/topology-manager.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,10 @@ resource allocation decisions.
6060

6161
## Windows Support
6262

63-
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
63+
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
6464

65-
The Topology Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature flag and requires a support in the container runtime.
65+
The Topology Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature gate and
66+
it requires a support in the container runtime.
6667

6768
## Topology manager scopes and policies
6869

0 commit comments

Comments
 (0)