Skip to content

Commit dfe6e0a

Browse files
SayakMukhopadhyaySayakMukhopadhyay
committed
feat: add comments to OWNERS to align them with other files
feat: add area/localization label to pl OWNERS file fix: OWNERS with filters should have the approvers and reviewers properties within the filters property feat: add filters in OWNERS files in <lang> dirs to ensure that they act on only the toml files feat: ensure OWNERS files have an indent size of 2
1 parent f5eee4f commit dfe6e0a

File tree

19 files changed

+174
-119
lines changed

19 files changed

+174
-119
lines changed

‎.editorconfig‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@ insert_final_newline = true
2121

2222
[Makefile]
2323
indent_style = tab
24+
25+
[OWNERS]
26+
indent_size = 2

‎assets/images/OWNERS‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@
44
# reviewers to review and approve.
55
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
66

7-
reviewers:
8-
- sig-docs-en-reviews
9-
10-
approvers:
11-
- sig-docs-en-owners
12-
137
filters:
8+
".*":
9+
reviewers:
10+
- sig-docs-en-reviews
11+
approvers:
12+
- sig-docs-en-owners
1413
"\\.svg":
1514
labels:
1615
- area/web-development

‎i18n/bn/OWNERS‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Localized strings for Bengali.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-bn-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-bn-owners
9+
reviewers:
10+
- sig-docs-bn-reviews
1111

12-
labels:
13-
- area/localization
14-
- language/bn
12+
approvers:
13+
- sig-docs-bn-owners
14+
15+
labels:
16+
- area/localization
17+
- language/bn

‎i18n/de/OWNERS‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Localized strings for German.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-de-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-de-owners
9+
reviewers:
10+
- sig-docs-de-reviews
1111

12-
labels:
13-
- area/localization
14-
- language/de
12+
approvers:
13+
- sig-docs-de-owners
14+
15+
labels:
16+
- area/localization
17+
- language/de

‎i18n/en/OWNERS‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,14 @@
33
# Upstream (English) localized strings.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-en-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-en-owners
9+
reviewers:
10+
- sig-docs-en-reviews
1111

12-
labels:
13-
- language/en
12+
approvers:
13+
- sig-docs-en-owners
14+
15+
labels:
16+
- language/en

‎i18n/es/OWNERS‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Localized strings for Spanish.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-es-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-es-owners
9+
reviewers:
10+
- sig-docs-es-reviews
1111

12-
labels:
13-
- area/localization
14-
- language/es
12+
approvers:
13+
- sig-docs-es-owners
14+
15+
labels:
16+
- area/localization
17+
- language/es

‎i18n/fr/OWNERS‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Localized strings for French.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-fr-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-fr-owners
9+
reviewers:
10+
- sig-docs-fr-reviews
1111

12-
labels:
13-
- area/localization
14-
- language/fr
12+
approvers:
13+
- sig-docs-fr-owners
14+
15+
labels:
16+
- area/localization
17+
- language/fr

‎i18n/hi/OWNERS‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Localized strings for Hindi.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-hi-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-hi-owners
9+
reviewers:
10+
- sig-docs-hi-reviews
1111

12-
labels:
13-
- area/localization
14-
- language/hi
12+
approvers:
13+
- sig-docs-hi-owners
14+
15+
labels:
16+
- area/localization
17+
- language/hi

‎i18n/id/OWNERS‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@
33
# Localized strings for Bahasa.
44
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
55

6-
reviewers:
7-
- sig-docs-id-reviews
6+
filters:
7+
"\\.toml$":
88

9-
approvers:
10-
- sig-docs-id-owners
9+
reviewers:
10+
- sig-docs-id-reviews
1111

12-
labels:
13-
- area/localization
14-
- language/id
12+
approvers:
13+
- sig-docs-id-owners
14+
15+
labels:
16+
- area/localization
17+
- language/id

‎i18n/it/OWNERS‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
1+
# See the OWNERS docs at https://go.k8s.io/owners
2+
13
# Localized strings for Italian.
24
# Teams and members are visible at https://github.com/orgs/kubernetes/teams.
35

4-
reviewers:
5-
- sig-docs-it-reviews
6+
filters:
7+
"\\.toml$":
8+
9+
reviewers:
10+
- sig-docs-it-reviews
611

7-
approvers:
8-
- sig-docs-it-owners
12+
approvers:
13+
- sig-docs-it-owners
914

10-
labels:
11-
- area/localization
12-
- language/it
15+
labels:
16+
- area/localization
17+
- language/it

0 commit comments

Comments
 (0)