Skip to content

Commit 26ed6a4

Browse files
committed
fix user service tests
1 parent 1fac960 commit 26ed6a4

File tree

1 file changed

+39
-5
lines changed

1 file changed

+39
-5
lines changed

server/src/users/users.service.spec.ts

Lines changed: 39 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,36 @@ describe('UsersService', () => {
4848
expect(user).toBe(mockUser);
4949
expect(prismaMock.user.findUnique).toHaveBeenCalledWith({
5050
where: { id: '1' },
51+
select: {
52+
id: true,
53+
username: true,
54+
email: true,
55+
firstName: true,
56+
lastName: true,
57+
image: true,
58+
provider: true,
59+
providerId: true,
60+
providerData: true,
61+
isActive: true,
62+
lastLogin: true,
63+
lastIp: true,
64+
createdAt: true,
65+
updatedAt: true,
66+
role: {
67+
select: {
68+
id: true,
69+
name: true,
70+
description: true,
71+
},
72+
},
73+
userGroups: {
74+
select: {
75+
id: true,
76+
name: true,
77+
description: true,
78+
},
79+
},
80+
},
5181
});
5282
});
5383

@@ -76,7 +106,10 @@ describe('UsersService', () => {
76106
const user = await service.create(newUser);
77107
expect(user).toBe(createdUser);
78108
expect(prismaMock.user.create).toHaveBeenCalledWith({
79-
data: expect.objectContaining(newUser),
109+
data: expect.objectContaining({
110+
username: 'user3',
111+
password: expect.any(String), // password will be hashed
112+
}),
80113
});
81114
});
82115

@@ -87,11 +120,12 @@ describe('UsersService', () => {
87120
password: 'newpass',
88121
} as PrismaUser;
89122
prismaMock.user.update.mockResolvedValueOnce(updatedUser);
90-
const user = await service.update('1', { password: 'newpass' });
91-
expect(user).toBe(updatedUser);
123+
const user = await service.update('1', { username: 'user2' });
124+
expect(user).toEqual(updatedUser); // Use toEqual instead of toBe
92125
expect(prismaMock.user.update).toHaveBeenCalledWith({
93126
where: { id: '1' },
94-
data: { password: 'newpass' },
127+
data: { username: 'user2' },
128+
omit: { password: true },
95129
});
96130
});
97131

@@ -112,7 +146,7 @@ describe('UsersService', () => {
112146
expect(user).toBe(updatedUser);
113147
expect(prismaMock.user.update).toHaveBeenCalledWith({
114148
where: { id: '1' },
115-
data: { password: 'newpass' },
149+
data: { password: expect.any(String) }, // password will be hashed
116150
});
117151
});
118152

0 commit comments

Comments
 (0)