Merge pull request #86 from waltforme/memleak

pdettori · web-flow · commit feb9f7571d98 · 2024-10-18T13:32:37.000-04:00
🌱 Let startInformers go
diff --git a/pkg/agent/informers.go b/pkg/agent/informers.go
@@ -52,13 +52,9 @@ func (a *Agent) startInformers(gvrs []*schema.GroupVersionResource, uids []strin
 		if count == 1 {
 			a.logger.Info("starting informer", "key", key)
 			stopper := make(chan struct{})
-			defer close(stopper)
 			a.startInformer(*gvr, gvk, stopper, true)
 		}
-
 	}
-	// block to avoid closing channel
-	select {}
 }
 
 func (a *Agent) startInformer(gvr schema.GroupVersionResource, gvk schema.GroupVersionKind, stopper chan struct{}, restartable bool) {

Original file line number	Diff line number	Diff line change
`@@ -52,13 +52,9 @@ func (a Agent) startInformers(gvrs []schema.GroupVersionResource, uids []strin`
`52`	`52`	`if count == 1 {`
`53`	`53`	`a.logger.Info("starting informer", "key", key)`
`54`	`54`	`stopper := make(chan struct{})`
`55`		`- defer close(stopper)`
`56`	`55`	`a.startInformer(*gvr, gvk, stopper, true)`
`57`	`56`	`}`
`58`		`-`
`59`	`57`	`}`
`60`		`- // block to avoid closing channel`
`61`		`- select {}`
`62`	`58`	`}`
`63`	`59`
`64`	`60`	`func (a *Agent) startInformer(gvr schema.GroupVersionResource, gvk schema.GroupVersionKind, stopper chan struct{}, restartable bool) {`