Resolves: MTV-3979 | Make VDDK edit modal consistent with wizard (#2169)

Signed-off-by: Aviv Turgeman <[email protected]>

Author: avivtur

locales/en/plugin__forklift-console-plugin.json

@@ -57,11 +57,11 @@
   "<0><0>Target provider <1>{targetProviderName}</1> does not have network mappings available in any existing projects.</0><1>Create a project or select a different target provider.</1></0>": "<0><0>Target provider <1>{targetProviderName}</1> does not have network mappings available in any existing projects.</0><1>Create a project or select a different target provider.</1></0>",
   "<0>Critical: </0> VM migration will fail due to this issue. Action must be taken to remove the critical concern.": "<0>Critical: </0> VM migration will fail due to this issue. Action must be taken to remove the critical concern.",
   "<0>Informational:</0> Will not cause a big impact on your VMs.": "<0>Informational:</0> Will not cause a big impact on your VMs.",
-  "<0>It is strongly recommended to use a VDDK image. Not using a VDDK image could result in significantly lower migration speeds or a plan failing. For more information, see <2>Creating a VDDK image</2>.</0>": "<0>It is strongly recommended to use a VDDK image. Not using a VDDK image could result in significantly lower migration speeds or a plan failing. For more information, see <2>Creating a VDDK image</2>.</0>",
   "<0>Link for the OpenShift Virtualization web console UI.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>": "<0>Link for the OpenShift Virtualization web console UI.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>",
   "<0>Link for the OpenStack dashboard UI.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>": "<0>Link for the OpenStack dashboard UI.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>",
   "<0>Link for the Red Hat Virtualization Manager landing page.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>": "<0>Link for the Red Hat Virtualization Manager landing page.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>",
   "<0>Link for the VMware vSphere UI.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>": "<0>Link for the VMware vSphere UI.</0><1>Use this link to access the user interface for the provider's virtualization management.</1><2>If no link value is specify then a default auto calculated or an empty value is set.</2>",
+  "<0>Not using a VDDK image could result in significantly lower migration speeds or a plan failing. For more information, see <2>Creating a VDDK image</2></0>": "<0>Not using a VDDK image could result in significantly lower migration speeds or a plan failing. For more information, see <2>Creating a VDDK image</2></0>",
   "<0>Open a support case</0> on your Red Hat Customer Portal and attach the compressed file.": "<0>Open a support case</0> on your Red Hat Customer Portal and attach the compressed file.",
   "<0>Select <1>Skip certificate validation</1> to skip certificate verification, which proceeds with an insecure migration and then the certificate is not required. Insecure migration means that the transferred data is sent over an insecure connection and potentially sensitive data could be exposed.</0>": "<0>Select <1>Skip certificate validation</1> to skip certificate verification, which proceeds with an insecure migration and then the certificate is not required. Insecure migration means that the transferred data is sent over an insecure connection and potentially sensitive data could be exposed.</0>",
   "<0>Start the {migrationType} migration for plan <4>{name}</4>?</0><1>{migrationMessage}</1>": "<0>Start the {migrationType} migration for plan <4>{name}</4>?</0><1>{migrationMessage}</1>",
@@ -354,7 +354,7 @@
   "Edit target name": "Edit target name",
   "Edit target power state": "Edit target power state",
   "Edit URL": "Edit URL",
-  "Edit VDDK init image": "Edit VDDK init image",
+  "Edit VDDK image": "Edit VDDK image",
   "Edit VM target affinity rules": "Edit VM target affinity rules",
   "Edit VM target labels": "Edit VM target labels",
   "Edit VM target node selector": "Edit VM target node selector",
@@ -521,6 +521,7 @@
   "Is the guest operating system of your source VM officially supported by OpenShift Virtualization?": "Is the guest operating system of your source VM officially supported by OpenShift Virtualization?",
   "Issuer": "Issuer",
   "Issues we have detected that might impact your virtual machines or their ability to migrate. There is no guarantee for a successful migration with any of the issues.": "Issues we have detected that might impact your virtual machines or their ability to migrate. There is no guarantee for a successful migration with any of the issues.",
+  "It is highly recommended to use a VDDK image.": "It is highly recommended to use a VDDK image.",
   "Jobs": "Jobs",
   "Key": "Key",
   "Key terminology": "Key terminology",
@@ -937,7 +938,6 @@
   "Skip guest conversion": "Skip guest conversion",
   "Skip to review": "Skip to review",
   "Skip VDDK setup (not recommended)": "Skip VDDK setup (not recommended)",
-  "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (not recommended).": "Skip VMware Virtual Disk Development Kit (VDDK) SDK acceleration (not recommended).",
   "Small precopy interval": "Small precopy interval",
   "Snapshot polling interval": "Snapshot polling interval",
   "Some fields may not be supported.": "Some fields may not be supported.",

src/modules/Providers/views/details/ProviderDetailsPage.style.css

@@ -1,4 +1,3 @@
-import { toNetworks } from 'src/modules/Providers/views/migrate/reducer/getNetworksUsedBySelectedVMs';
 import { PROVIDER_TYPES } from 'src/providers/utils/constants';
 
 import type {
@@ -16,7 +15,6 @@ import { hasMultiplePodNetworkMappings } from '../../utils/hasMultiplePodNetwork
 import { getMapResourceLabel } from '../utils';
 
 import { defaultNetMapping, NetworkMapFieldId, type NetworkMapping } from './constants';
-
 type NetworkMappingId = `${NetworkMapFieldId.NetworkMap}.${number}.${keyof NetworkMapping}`;
 
 type ValidateNetworkMapParams = {
@@ -26,6 +24,54 @@ type ValidateNetworkMapParams = {
   oVirtNicProfiles: OVirtNicProfile[];
 };
 
+import type { EnhancedOvaVM } from '@utils/crds/plans/type-enhancements';
+
+const toNetworksOrProfiles = (vm: ProviderVirtualMachine): string[] => {
+  switch (vm.providerType) {
+    case 'vsphere': {
+      return vm?.networks?.map((network) => network?.id) ?? [];
+    }
+    case 'openstack': {
+      return Object.keys(vm?.addresses ?? {});
+    }
+    case 'ovirt': {
+      return vm?.nics?.map((nic) => nic?.profile) ?? [];
+    }
+    case 'openshift': {
+      return (vm?.object?.spec?.template?.spec?.networks ?? []).reduce((acc: string[], network) => {
+        const networkName = network?.multus?.networkName ?? network?.name;
+
+        if (network?.pod) {
+          acc.push(DEFAULT_NETWORK);
+        } else if (networkName) {
+          acc.push(networkName);
+        }
+        return acc;
+      }, []);
+    }
+    case 'ova': {
+      return (vm as EnhancedOvaVM)?.networks?.map((network) => network.ID) ?? [];
+    }
+    default:
+      return [];
+  }
+};
+
+const toNetworks = (vm: ProviderVirtualMachine, nicProfiles?: OVirtNicProfile[]): string[] => {
+  return toNetworksOrProfiles(vm).reduce((acc: string[], network) => {
+    const nicProfileNetwork = nicProfiles?.find(
+      (nicProfile) => nicProfile?.id === network,
+    )?.network;
+    if (vm.providerType === 'ovirt' && nicProfileNetwork) {
+      acc.push(nicProfileNetwork);
+    } else {
+      acc.push(network);
+    }
+
+    return acc;
+  }, []);
+};
+
 /**
  * Creates a field ID for a network mapping at a specific index
  * Used for form field identification and validation

src/modules/Providers/views/migrate/reducer/getNetworksUsedBySelectedVMs.ts

@@ -0,0 +1,30 @@
+import type { FC } from 'react';
+import { CREATE_VDDK_HELP_LINK } from 'src/plans/details/utils/constants';
+
+import { ExternalLink } from '@components/common/ExternalLink/ExternalLink';
+import { Alert, AlertVariant } from '@patternfly/react-core';
+import { ForkliftTrans, useForkliftTranslation } from '@utils/i18n';
+
+const SkipVddkAlert: FC = () => {
+  const { t } = useForkliftTranslation();
+
+  return (
+    <Alert
+      variant={AlertVariant.warning}
+      isInline
+      title={t('It is highly recommended to use a VDDK image.')}
+    >
+      <ForkliftTrans>
+        <p>
+          Not using a VDDK image could result in significantly lower migration speeds or a plan
+          failing. For more information, see{' '}
+          <ExternalLink isInline href={CREATE_VDDK_HELP_LINK}>
+            Creating a VDDK image
+          </ExternalLink>
+        </p>
+      </ForkliftTrans>
+    </Alert>
+  );
+};
+
+export default SkipVddkAlert;

src/plans/create/steps/network-map/utils.ts

@@ -0,0 +1,34 @@
+import type { FC } from 'react';
+import { useController, useFormContext } from 'react-hook-form';
+
+import { Checkbox } from '@patternfly/react-core';
+import { useForkliftTranslation } from '@utils/i18n';
+
+import { ProviderFormFieldId } from '../create/fields/constants';
+
+const VDDKAioOptimizationCheckbox: FC = () => {
+  const { t } = useForkliftTranslation();
+
+  const { control } = useFormContext();
+
+  const {
+    field: { onChange, value },
+  } = useController({
+    control,
+    name: ProviderFormFieldId.VsphereUseVddkAioOptimization,
+  });
+
+  return (
+    <Checkbox
+      label={t('Use VMware Virtual Disk Development Kit (VDDK) async IO Optimization.')}
+      isChecked={value}
+      onChange={onChange}
+      id={ProviderFormFieldId.VsphereUseVddkAioOptimization}
+      name={ProviderFormFieldId.VsphereUseVddkAioOptimization}
+      data-testid="vddk-aio-optimization-checkbox"
+      className="pf-v6-u-mt-xs"
+    />
+  );
+};
+
+export default VDDKAioOptimizationCheckbox;