Add appliance management UI input for OVA providers

Add checkbox field to enable appliance management when creating OVA
providers and in the provider details page. This setting controls
whether users can upload OVA files directly to the provider.

Changes:
- Add checkbox in create provider form for OVA type
- Add details item with edit capability in OVA provider details page
- Add E2E test verification for appliance management setting

Resolves: MTV-4481
Signed-off-by: Aviv Turgeman <[email protected]>

Author: avivtur

Claude.md

@@ -34,16 +34,24 @@ This is an **OpenShift Console dynamic plugin** for [Forklift](https://github.co
    }
    ```
 
-2. **Use inline type imports**:
-   ```typescript
-   // ✅ Good
-   import { type FC, useState } from 'react';
-   import { type UserProps } from './types';
-
-   // ❌ Bad
-   import type { FC } from 'react';
-   import { useState } from 'react';
-   ```
+2. **Type imports**:
+   - If **all** imports from a module are types, use `import type`:
+     ```typescript
+     // ✅ Good - all imports are types
+     import type { FC, ReactNode } from 'react';
+     import type { UserProps } from './types';
+     ```
+   - If **some** imports are types and some are values, use inline `type` keyword:
+     ```typescript
+     // ✅ Good - mixed types and values
+     import { type FC, useState, type ReactNode } from 'react';
+     ```
+   - Never separate type and value imports from the same module:
+     ```typescript
+     // ❌ Bad - separate imports from same module
+     import type { FC } from 'react';
+     import { useState } from 'react';
+     ```
 
 3. **Strict null checks are enabled** - always handle nullable values properly.
 

locales/en/plugin__forklift-console-plugin.json

@@ -152,6 +152,7 @@
   "Ansible playbook. If you specify a playbook, the image must be hook-runner.": "Ansible playbook. If you specify a playbook, the image must be hook-runner.",
   "Any underscore (_) is changed to a dash (-).": "Any underscore (_) is changed to a dash (-).",
   "API endpoint URL": "API endpoint URL",
+  "Appliance management": "Appliance management",
   "Application credential ID": "Application credential ID",
   "Application credential ID:": "Application credential ID:",
   "Application credential name": "Application credential name",
@@ -363,6 +364,7 @@
   "Edit {{hookTypeLowercase}} migration hook": "Edit {{hookTypeLowercase}} migration hook",
   "Edit affinity rule": "Edit affinity rule",
   "Edit Ansible hook configuration for your migration plan. Hooks are applied to all virtual machines in the plan.": "Edit Ansible hook configuration for your migration plan. Hooks are applied to all virtual machines in the plan.",
+  "Edit appliance management": "Edit appliance management",
   "Edit cutover": "Edit cutover",
   "Edit default transfer network": "Edit default transfer network",
   "Edit description": "Edit description",
@@ -392,6 +394,7 @@
   "Edit volume name template": "Edit volume name template",
   "Empty": "Empty",
   "Enable {{hookTypeLowercase}} migration hook": "Enable {{hookTypeLowercase}} migration hook",
+  "Enable appliance management for local OVA file uploads": "Enable appliance management for local OVA file uploads",
   "Enabled": "Enabled",
   "Enables hardware-assisted copying by instructing the vSphere ESXi host to transfer data directly on the storage backend using technologies like XCOPY and VAAI.": "Enables hardware-assisted copying by instructing the vSphere ESXi host to transfer data directly on the storage backend using technologies like XCOPY and VAAI.",
   "Endpoint": "Endpoint",
@@ -1345,6 +1348,7 @@
   "Weight must be a number between 1-100": "Weight must be a number between 1-100",
   "Welcome": "Welcome",
   "What type of provider do you want to create?": "What type of provider do you want to create?",
+  "When enabled, allows uploading OVA files directly to the provider instead of using NFS shared directory only.": "When enabled, allows uploading OVA files directly to the provider instead of using NFS shared directory only.",
   "When the URL field is left empty, the local OpenShift cluster is used.": "When the URL field is left empty, the local OpenShift cluster is used.",
   "When the VM will migrate during a warm migration. VMs included in the migration plan will be shut down when the cutover starts.": "When the VM will migrate during a warm migration. VMs included in the migration plan will be shut down when the cutover starts.",
   "When you migrate from OpenStack, or when you run a cold migration from Red Hat Virtualization to the Red Hat OpenShift cluster that MTV is deployed on, the migration allocates persistent volumes without CDI. In these cases, you might need to adjust the file system overhead.": "When you migrate from OpenStack, or when you run a cold migration from Red Hat Virtualization to the Red Hat OpenShift cluster that MTV is deployed on, the migration allocates persistent volumes without CDI. In these cases, you might need to adjust the file system overhead.",

src/providers/create/ProviderTypeFields.tsx

@@ -15,6 +15,7 @@ import ServiceAccountTokenField from './fields/openshift/ServiceAccountTokenFiel
 import OpenStackAuthenticationTypeField from './fields/openstack/OpenStackAuthenticationTypeField';
 import OpenStackUrlField from './fields/openstack/OpenStackUrlField';
 import NfsDirectoryField from './fields/ova/NfsDirectoryField';
+import OvaApplianceManagementField from './fields/ova/OvaApplianceManagementField';
 import OvirtCredentialsFields from './fields/ovirt/OvirtCredentialsFields';
 import OvirtUrlField from './fields/ovirt/OvirtUrlField';
 import ProviderNameField from './fields/ProviderNameField';
@@ -48,7 +49,12 @@ const ProviderTypeFields: FC = () => {
 
       {selectedProviderType && <ProviderNameField />}
 
-      {selectedProviderType === PROVIDER_TYPES.ova && <NfsDirectoryField />}
+      {selectedProviderType === PROVIDER_TYPES.ova && (
+        <>
+          <NfsDirectoryField />
+          <OvaApplianceManagementField />
+        </>
+      )}
 
       {selectedProviderType === PROVIDER_TYPES.openshift && (
         <>

src/providers/create/fields/constants.ts

@@ -40,6 +40,7 @@ enum OpenstackProviderFormFieldId {
 
 enum OvaProviderFormFieldId {
   NfsDirectory = 'nfsDirectory',
+  OvaApplianceManagement = 'ovaApplianceManagement',
 }
 
 enum OvirtProviderFormFieldId {

src/providers/create/fields/ova/OvaApplianceManagementField.tsx

@@ -0,0 +1,40 @@
+import type { FC } from 'react';
+import { useController } from 'react-hook-form';
+import {
+  OVA_APPLIANCE_MANAGEMENT_DESCRIPTION,
+  OVA_APPLIANCE_MANAGEMENT_LABEL,
+} from 'src/providers/utils/constants';
+
+import { Checkbox, FormGroup } from '@patternfly/react-core';
+
+import { useCreateProviderFormContext } from '../../hooks/useCreateProviderFormContext';
+import { ProviderFormFieldId } from '../constants';
+
+const OvaApplianceManagementField: FC = () => {
+  const { control } = useCreateProviderFormContext();
+
+  const {
+    field: { onChange, value },
+  } = useController({
+    control,
+    name: ProviderFormFieldId.OvaApplianceManagement,
+  });
+
+  return (
+    <FormGroup fieldId={ProviderFormFieldId.OvaApplianceManagement}>
+      <Checkbox
+        label={OVA_APPLIANCE_MANAGEMENT_LABEL}
+        isChecked={value ?? false}
+        onChange={(_event, checked) => {
+          onChange(checked);
+        }}
+        id={ProviderFormFieldId.OvaApplianceManagement}
+        name={ProviderFormFieldId.OvaApplianceManagement}
+        data-testid="ova-appliance-management-checkbox"
+        description={OVA_APPLIANCE_MANAGEMENT_DESCRIPTION}
+      />
+    </FormGroup>
+  );
+};
+
+export default OvaApplianceManagementField;

src/providers/create/types.ts

@@ -23,6 +23,7 @@ type OpenshiftFields = {
 
 type OvaFields = {
   [ProviderFormFieldId.NfsDirectory]?: string;
+  [ProviderFormFieldId.OvaApplianceManagement]?: boolean;
 };
 
 type HypervFields = {

src/providers/create/utils/buildOvaProviderResources.ts

@@ -1,4 +1,4 @@
-import { PROVIDER_TYPES } from 'src/providers/utils/constants';
+import { PROVIDER_TYPES, TRUE_VALUE } from 'src/providers/utils/constants';
 
 import type { IoK8sApiCoreV1Secret, V1beta1Provider } from '@forklift-ui/types';
 
@@ -17,6 +17,7 @@ export const buildOvaProviderResources = (formData: OvaFormData): ProviderResour
   const namespace = formData[ProviderFormFieldId.ProviderProject];
   const providerName = formData[ProviderFormFieldId.ProviderName];
   const nfsDirectory = formData[ProviderFormFieldId.NfsDirectory] ?? '';
+  const applianceManagement = formData[ProviderFormFieldId.OvaApplianceManagement];
 
   const provider = buildProviderObject({
     name: providerName,
@@ -25,6 +26,13 @@ export const buildOvaProviderResources = (formData: OvaFormData): ProviderResour
     url: nfsDirectory,
   });
 
+  if (applianceManagement && provider.spec) {
+    provider.spec.settings = {
+      ...provider.spec.settings,
+      applianceManagement: TRUE_VALUE,
+    };
+  }
+
   const secret = buildSecretObject({
     namespace,
   });

src/providers/details/tabs/Details/components/DetailsSection/ApplianceManagementDetailsItem.tsx

@@ -0,0 +1,51 @@
+import type { FC } from 'react';
+import { DetailsItem } from 'src/components/DetailItems/DetailItem';
+import { OVA_APPLIANCE_MANAGEMENT_DESCRIPTION } from 'src/providers/utils/constants';
+
+import { useModal } from '@openshift-console/dynamic-plugin-sdk';
+import { Label } from '@patternfly/react-core';
+import { getApplianceManagement } from '@utils/crds/common/selectors';
+import { useForkliftTranslation } from '@utils/i18n';
+
+import type { ProviderDetailsItemProps } from './utils/types';
+import EditApplianceManagement, {
+  type EditApplianceManagementProps,
+} from './EditApplianceManagement';
+
+const ApplianceManagementDetailsItem: FC<ProviderDetailsItemProps> = ({
+  canPatch,
+  helpContent,
+  resource: provider,
+}) => {
+  const { t } = useForkliftTranslation();
+  const launcher = useModal();
+
+  const applianceManagement = getApplianceManagement(provider);
+  const isEnabled = applianceManagement === 'true';
+
+  return (
+    <DetailsItem
+      testId="appliance-management-detail-item"
+      title={t('Appliance management')}
+      content={
+        isEnabled ? (
+          <Label isCompact status="success">
+            {t('Enabled')}
+          </Label>
+        ) : (
+          <Label isCompact status="info">
+            {t('Disabled')}
+          </Label>
+        )
+      }
+      helpContent={helpContent ?? OVA_APPLIANCE_MANAGEMENT_DESCRIPTION}
+      crumbs={['Provider', 'spec', 'settings', 'applianceManagement']}
+      onEdit={() => {
+        launcher<EditApplianceManagementProps>(EditApplianceManagement, { provider });
+      }}
+      canEdit={canPatch}
+    />
+  );
+};
+
+export default ApplianceManagementDetailsItem;

src/providers/details/tabs/Details/components/DetailsSection/EditApplianceManagement.tsx

@@ -0,0 +1,54 @@
+import { useState } from 'react';
+import {
+  OVA_APPLIANCE_MANAGEMENT_DESCRIPTION,
+  OVA_APPLIANCE_MANAGEMENT_LABEL,
+} from 'src/providers/utils/constants';
+import { useForkliftTranslation } from 'src/utils/i18n';
+
+import ModalForm from '@components/ModalForm/ModalForm';
+import type { V1beta1Provider } from '@forklift-ui/types';
+import type { ModalComponent } from '@openshift-console/dynamic-plugin-sdk/lib/app/modal-support/ModalProvider';
+import { Checkbox, Form, FormGroup } from '@patternfly/react-core';
+import { getApplianceManagement } from '@utils/crds/common/selectors';
+
+import onUpdateApplianceManagement from './onUpdateApplianceManagement';
+
+export type EditApplianceManagementProps = {
+  provider: V1beta1Provider;
+};
+
+const EditApplianceManagement: ModalComponent<EditApplianceManagementProps> = ({
+  closeModal,
+  provider,
+}) => {
+  const { t } = useForkliftTranslation();
+
+  const currentValue = getApplianceManagement(provider) === 'true';
+  const [enabled, setEnabled] = useState(currentValue);
+
+  const onSubmit = async (): Promise<void> => {
+    await onUpdateApplianceManagement(provider, enabled);
+  };
+
+  return (
+    <ModalForm closeModal={closeModal} title={t('Edit appliance management')} onConfirm={onSubmit}>
+      <Form>
+        <FormGroup fieldId="appliance-management">
+          <Checkbox
+            label={OVA_APPLIANCE_MANAGEMENT_LABEL}
+            isChecked={enabled}
+            onChange={(_event, checked) => {
+              setEnabled(checked);
+            }}
+            id="appliance-management-checkbox"
+            name="appliance-management"
+            data-testid="edit-appliance-management-checkbox"
+            description={OVA_APPLIANCE_MANAGEMENT_DESCRIPTION}
+          />
+        </FormGroup>
+      </Form>
+    </ModalForm>
+  );
+};
+
+export default EditApplianceManagement;

src/providers/details/tabs/Details/components/DetailsSection/OVADetailsSection.tsx

@@ -10,13 +10,16 @@ import OwnerDetailsItem from '@components/DetailItems/OwnerDetailItem';
 import { DescriptionList } from '@patternfly/react-core';
 
 import type { DetailsSectionProps } from './utils/types';
+import ApplianceManagementDetailsItem from './ApplianceManagementDetailsItem';
 
 const OVADetailsSection: FC<DetailsSectionProps> = ({ data }) => {
   const { t } = useForkliftTranslation();
-  const { provider } = data;
+  const { permissions, provider } = data;
 
   if (!provider) return null;
 
+  const canPatch = permissions?.canPatch ?? false;
+
   return (
     <DescriptionList
       columnModifier={{
@@ -33,6 +36,7 @@ const OVADetailsSection: FC<DetailsSectionProps> = ({ data }) => {
           `URL of the NFS file share that serves the OVA., for example, 10.10.0.10:/ova`,
         )}
       />
+      <ApplianceManagementDetailsItem resource={provider} canPatch={canPatch} />
       <CreatedAtDetailsItem resource={provider} />
       <OwnerDetailsItem resource={provider} />
     </DescriptionList>