ECOPROJECT-4097 | feat: warning on new agent VM version released

Signed-off-by: Ronen Avraham <ravraham@redhat.com>

Author: ronenav

api/v1alpha1/agent/spec.gen.go

@@ -1035,6 +1035,14 @@ components:
               $ref: "#/components/schemas/ValidatedSSHPublicKey"
             vmNetwork:
               $ref: "#/components/schemas/VmNetwork"
+        agentVersion:
+          type: string
+          nullable: true
+          description: Agent version (version tag) stored when OVA was downloaded
+        agentVersionWarning:
+          type: string
+          nullable: true
+          description: Warning message if stored agent version differs from current agent version
       required:
         - id
         - name

api/v1alpha1/openapi.yaml

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"net/http"
 	"strconv"
+	"time"
 
 	"github.com/golang-jwt/jwt/v4"
 	"github.com/google/uuid"
@@ -17,6 +18,7 @@ import (
 	"github.com/kubev2v/migration-planner/internal/store"
 	"github.com/kubev2v/migration-planner/internal/store/model"
 	"github.com/kubev2v/migration-planner/pkg/metrics"
+	"github.com/kubev2v/migration-planner/pkg/version"
 	"go.uber.org/zap"
 )
 
@@ -102,6 +104,22 @@ func (h *ImageHandler) GetImageByToken(ctx context.Context, req imageServer.GetI
 
 	metrics.IncreaseOvaDownloadsTotalMetric("successful")
 
+	versionInfo := version.Get()
+	if !version.IsValidAgentVersion(versionInfo.AgentVersionName) {
+		zap.S().Named("image_service").Warnw("agent version not valid, skipping storage", "source_id", source.ID, "agent_version_name", versionInfo.AgentVersionName, "agent_git_commit", versionInfo.AgentGitCommit)
+	} else {
+		// Use detached context to ensure version persists even if client disconnects
+		persistCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
+		defer cancel()
+
+		// Use atomic update to prevent race conditions during concurrent downloads
+		if err := h.store.ImageInfra().UpdateAgentVersion(persistCtx, source.ID.String(), versionInfo.AgentVersionName); err != nil {
+			zap.S().Named("image_service").Warnw("failed to update agent version", "error", err, "source_id", source.ID, "agent_version", versionInfo.AgentVersionName)
+		} else {
+			zap.S().Named("image_service").Infow("stored agent version", "source_id", source.ID, "agent_version", versionInfo.AgentVersionName)
+		}
+	}
+
 	return imageServer.GetImageByToken200ApplicationovfResponse{Body: bytes.NewReader([]byte{})}, nil
 }
 

api/v1alpha1/spec.gen.go

@@ -29,3 +29,26 @@ func TestGetInfo(t *testing.T) {
 	// GitVersion should at least have the default "unknown" value
 	assert.NotEmpty(t, successResponse.VersionName, "GitVersion should not be empty")
 }
+
+func TestGetInfo_AgentFields(t *testing.T) {
+	handler := &ServiceHandler{}
+	ctx := context.Background()
+	request := server.GetInfoRequestObject{}
+
+	response, err := handler.GetInfo(ctx, request)
+
+	assert.NoError(t, err)
+	assert.NotNil(t, response)
+
+	successResponse, ok := response.(server.GetInfo200JSONResponse)
+	assert.True(t, ok, "Response should be GetInfo200JSONResponse")
+
+	// Agent fields are optional - if set, they should be non-empty
+	// If not set (nil), that's also valid (may be empty in test builds)
+	if successResponse.AgentGitCommit != nil {
+		assert.NotEmpty(t, *successResponse.AgentGitCommit, "AgentGitCommit should not be empty if set")
+	}
+	if successResponse.AgentVersionName != nil {
+		assert.NotEmpty(t, *successResponse.AgentVersionName, "AgentVersionName should not be empty if set")
+	}
+}

api/v1alpha1/types.gen.go

@@ -155,6 +155,14 @@ func SourceToApi(s model.Source) (api.Source, error) {
 		}
 	}
 
+	// Map agent version and warning (from ImageInfra, independent of agents)
+	if s.ImageInfra.AgentVersion != nil {
+		source.AgentVersion = s.ImageInfra.AgentVersion
+	}
+	if warning := service.CheckAgentVersionWarning(&s.ImageInfra); warning != nil {
+		source.AgentVersionWarning = warning
+	}
+
 	// We are mapping only the first agent based on created_at timestamp and ignore the rest for now.
 	// TODO:
 	// Remark: If multiple agents are deployed, we pass only the first one based on created_at timestamp