NO-JIRA | fix: improve name validation error messages

- Updated ValidateName() error message to include valid format guidance
- Added explicit name validation in assessment handler before struct validation
- Both RVTools and assessment flows now return consistent descriptive errors

Signed-off-by: yjacobi <yjacobi@redhat.com>

Author: Jos-Jerus

internal/handlers/v1alpha1/assessment.go

@@ -65,6 +65,13 @@ func (h *ServiceHandler) CreateAssessment(ctx context.Context, request server.Cr
 	}
 
 	form := v1alpha1.AssessmentForm(*request.Body)
+
+	// Validate name first for better error message
+	if err := validator.ValidateName(string(form.Name)); err != nil {
+		logger.Error(err).WithString("step", "validation").Log()
+		return server.CreateAssessment400JSONResponse{Message: err.Error()}, nil
+	}
+
 	if err := validateAssessmentData(form); err != nil {
 		logger.Error(err).WithString("step", "validation").Log()
 		return server.CreateAssessment400JSONResponse{Message: err.Error()}, nil

internal/handlers/validator/custom.go

@@ -39,7 +39,10 @@ func nameValidator(fl validator.FieldLevel) bool {
 func ValidateName(name string) error {
 	ok := nameValidRegex.MatchString(name)
 	if !ok {
-		return NewErrInvalidName("The provided name: %s is invalid.", name)
+		return NewErrInvalidName(
+			"The provided name %q is invalid. Name must be 1-100 characters and contain only letters, numbers, underscores, periods, or hyphens (no spaces).",
+			name,
+		)
 	}
 
 	return nil