Merge pull request #3460 from upalatucci/CNV-79681-fix-vmim-name-length

CNV-79681: Fix VMIM name exceeding K8s max name length

Author: openshift-merge-bot[bot]

src/views/virtualmachines/actions/actions.ts

@@ -8,7 +8,8 @@ import {
   V1VirtualMachine,
   V1VirtualMachineInstanceMigration,
 } from '@kubevirt-ui-ext/kubevirt-api/kubevirt';
-import { kubevirtConsole } from '@kubevirt-utils/utils/utils';
+import { MAX_K8S_NAME_LENGTH } from '@kubevirt-utils/utils/constants';
+import { getRandomChars, kubevirtConsole } from '@kubevirt-utils/utils/utils';
 import { getCluster } from '@multicluster/helpers/selectors';
 import {
   getKubevirtBaseAPIPath,
@@ -17,8 +18,6 @@ import {
 } from '@multicluster/k8sRequests';
 import { consoleFetch, K8sModel } from '@openshift-console/dynamic-plugin-sdk';
 
-export const generateRandomString = () => Math.random().toString(36).substring(2, 7);
-
 export enum VMActionType {
   AddVolume = 'addvolume',
   Pause = 'pause',
@@ -85,11 +84,14 @@ export const removeVolume = async (vm: V1VirtualMachine, body: V1RemoveVolumeOpt
   VMActionRequest(vm, VMActionType.RemoveVolume, VirtualMachineModel, body);
 export const migrateVM = async (vm: V1VirtualMachine, node?: string) => {
   const { name, namespace } = vm?.metadata;
+  const suffix = `-mig-${getRandomChars(4)}`;
+  const truncatedName = name.substring(0, MAX_K8S_NAME_LENGTH - suffix.length);
+
   const migrationData: V1VirtualMachineInstanceMigration = {
     apiVersion: 'kubevirt.io/v1',
     kind: 'VirtualMachineInstanceMigration',
     metadata: {
-      name: `${name}-migration-${generateRandomString()}`,
+      name: `${truncatedName}${suffix}`,
     },
     spec: {
       vmiName: name,