-
Notifications
You must be signed in to change notification settings - Fork 175
Description
We need to look into whether we can add some logic to avoid re-running lanes that already have a succeeded status.
Target for that is the handle func inside the phased external plugin:
| func (h *GitHubEventsHandler) handlePullRequestEvent(log *logrus.Entry, event *github.PullRequestEvent) { |
Original discussion (snippet):
Required labels detected, running phase 2 presubmits: /test pull-kubevirt-e2e-k8s-1.34-windows2016 /test pull-kubevirt-e2e-kind-1.33-vgpu /test pull-kubevirt-e2e-kind-sriov /test pull-kubevirt-e2e-k8s-1.34-ipv6-sig-network /test pull-kubevirt-e2e-k8s-1.32-sig-network /test pull-kubevirt-e2e-k8s-1.32-sig-storage /test pull-kubevirt-e2e-k8s-1.32-sig-compute /test pull-kubevirt-e2e-k8s-1.32-sig-operator /test pull-kubevirt-e2e-k8s-1.33-sig-network /test pull-kubevirt-e2e-k8s-1.33-sig-storage /test pull-kubevirt-e2e-k8s-1.33-sig-compute /test pull-kubevirt-e2e-k8s-1.33-sig-operator
@oshoval hmm, I was seeing that until the phased plugin retriggered the test lanes they had been green - we might think about a change in the phased plugin to check each lane status before it is added to the set of lanes to be triggered. WDYT?
FYI @dollierp
Originally posted by @dhiller in kubevirt/kubevirt#16645 (comment)