Skip to content

Commit ce5d6fd

Browse files
author
Hector Arce De Las Heras
committed
Refined Error and Help Message Display in Input Component
This pull request introduces significant improvements to the input component, focusing on the refactoring and enhancement of error and help message displays. Additionally, it addresses fixes in the counter container. The modifications span across the introduction of new prop types, updates to styled components, and revisions in style definitions, aiming to enhance flexibility and maintainability
1 parent 90b6442 commit ce5d6fd

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

src/components/input/input.styled.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { getStyles } from '@/utils/getStyles/getStyles';
1414
import { InputCounterStateProps } from '../inputCounter/types/inputCounterTheme';
1515
import { InputIconPosition, InputState } from './types';
1616
import {
17+
ErrorAndHelpMessageWrapperStyledProps,
1718
ErrorMessageStyledProps,
1819
HelpMessageStyledProps,
1920
InformationAssociatedStyledProps,
@@ -49,10 +50,8 @@ export const InfoAssociatedTextAndDecorativeStyled = styled.div<InformationAssoc
4950

5051
export const InfoAssociatedButtonStyled = styled.div<InformationAssociatedStyledProps>``;
5152

52-
export const InputErrorAndHelpMessageWrapperStyled = styled.div`
53-
display: flex;
54-
flex-direction: column;
55-
width: 100%;
53+
export const InputErrorAndHelpMessageWrapperStyled = styled.div<ErrorAndHelpMessageWrapperStyledProps>`
54+
${({ styles }) => getStyles(styles?.errorAndHelpMessageContainer)};
5655
`;
5756

5857
export const InputErrorStyled = styled.div<ErrorMessageStyledProps>`

src/components/input/inputStandAlone.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ const InputStandAloneComponent = (
9696
iconPosition={props.iconPosition}
9797
id={props.inputId}
9898
inputMode={inputMode}
99-
labelType={styles?.[state]?.label?.type}
10099
leftIcon={props.leftIcon}
101100
max={props.max}
102101
maxLength={props.maxLength}
@@ -201,7 +200,7 @@ const InputStandAloneComponent = (
201200
styles={styles?.[state]}
202201
/>
203202
<MessagesAndCounterWrapperStyled>
204-
<InputErrorAndHelpMessageWrapperStyled>
203+
<InputErrorAndHelpMessageWrapperStyled styles={styles?.[state]}>
205204
<ErrorMessageStandAlone
206205
dataTestId={props.dataTestId}
207206
errorAriaLiveType={props.errorAriaLiveType}

src/components/input/types/inputStyledPropsType.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ export type InformationAssociatedStyledProps = {
2222
styles?: InputStateProps;
2323
};
2424

25+
export type ErrorAndHelpMessageWrapperStyledProps = {
26+
styles?: InputStateProps;
27+
};
28+
2529
export type ErrorMessageStyledProps = {
2630
styles?: InputStateProps;
2731
};
@@ -69,7 +73,6 @@ export type InputStyledProps = {
6973
};
7074

7175
export type InputWrapperStyledProps = {
72-
iconPosition?: InputIconPosition;
7376
styles?: InputStateProps;
7477
labelType?: LABEL_TYPE;
7578
};

src/components/input/types/inputTheme.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ export type InputBasicStateProps = {
7373
size: string;
7474
};
7575
informationAssociatedButtonContainer?: CommonStyleType;
76+
errorAndHelpMessageContainer?: CommonStyleType;
7677
errorMessage?: TypographyTypes;
7778
errorMessageContainer?: CommonStyleType;
7879
errorMessageIcon?: IconTypes;

0 commit comments

Comments
 (0)