Use default named values where appropriate

Author: kubkon

src/Archive.zig

@@ -1,4 +1,4 @@
-objects: std.ArrayListUnmanaged(Object) = .{},
+objects: std.ArrayListUnmanaged(Object) = .empty,
 
 // Archive files start with the ARMAG identifying string.  Then follows a
 // `struct ar_hdr', and as many bytes of member file data as its `ar_size'

src/Atom.zig

@@ -23,7 +23,7 @@ n_sect: u32 = 0,
 value: u64 = 0,
 
 /// Name of this Atom.
-name: MachO.String = .{},
+name: MachO.String = .init,
 
 /// Index of the output section.
 out_n_sect: u8 = 0,

src/CodeSignature.zig

@@ -52,7 +52,7 @@ const CodeDirectory = struct {
     inner: macho.CodeDirectory,
     ident: []const u8,
     special_slots: [n_special_slots][hash_size]u8,
-    code_slots: std.ArrayListUnmanaged([hash_size]u8) = .{},
+    code_slots: std.ArrayListUnmanaged([hash_size]u8) = .empty,
 
     const n_special_slots: usize = 7;
 

src/Dylib.zig

@@ -5,16 +5,16 @@ index: File.Index,
 file_handle: ?File.HandleIndex = null,
 lib_stub: ?LibStub = null,
 
-exports: std.MultiArrayList(Export) = .{},
-strtab: std.ArrayListUnmanaged(u8) = .{},
+exports: std.MultiArrayList(Export) = .empty,
+strtab: std.ArrayListUnmanaged(u8) = .empty,
 id: ?Id = null,
 ordinal: u16 = 0,
 
-symbols: std.ArrayListUnmanaged(Symbol) = .{},
-symbols_extra: std.ArrayListUnmanaged(u32) = .{},
-globals: std.ArrayListUnmanaged(MachO.SymbolResolver.Index) = .{},
-dependents: std.ArrayListUnmanaged(Id) = .{},
-rpaths: std.StringArrayHashMapUnmanaged(void) = .{},
+symbols: std.ArrayListUnmanaged(Symbol) = .empty,
+symbols_extra: std.ArrayListUnmanaged(u32) = .empty,
+globals: std.ArrayListUnmanaged(MachO.SymbolResolver.Index) = .empty,
+dependents: std.ArrayListUnmanaged(Id) = .empty,
+rpaths: std.StringArrayHashMapUnmanaged(void) = .empty,
 umbrella: File.Index,
 
 needed: bool,
@@ -24,7 +24,7 @@ explicit: bool,
 hoisted: bool = true,
 referenced: bool = false,
 
-output_symtab_ctx: MachO.SymtabCtx = .{},
+output_symtab_ctx: MachO.SymtabCtx = .init,
 
 pub fn deinit(self: *Dylib, allocator: Allocator) void {
     if (self.lib_stub) |*ls| ls.deinit();

src/InternalObject.zig

@@ -1,29 +1,29 @@
 index: File.Index,
 
-sections: std.MultiArrayList(Section) = .{},
-atoms: std.ArrayListUnmanaged(Atom) = .{},
-atoms_indexes: std.ArrayListUnmanaged(Atom.Index) = .{},
-atoms_extra: std.ArrayListUnmanaged(u32) = .{},
-symtab: std.ArrayListUnmanaged(macho.nlist_64) = .{},
-strtab: std.ArrayListUnmanaged(u8) = .{},
-symbols: std.ArrayListUnmanaged(Symbol) = .{},
-symbols_extra: std.ArrayListUnmanaged(u32) = .{},
-globals: std.ArrayListUnmanaged(MachO.SymbolResolver.Index) = .{},
-
-objc_methnames: std.ArrayListUnmanaged(u8) = .{},
+sections: std.MultiArrayList(Section) = .empty,
+atoms: std.ArrayListUnmanaged(Atom) = .empty,
+atoms_indexes: std.ArrayListUnmanaged(Atom.Index) = .empty,
+atoms_extra: std.ArrayListUnmanaged(u32) = .empty,
+symtab: std.ArrayListUnmanaged(macho.nlist_64) = .empty,
+strtab: std.ArrayListUnmanaged(u8) = .empty,
+symbols: std.ArrayListUnmanaged(Symbol) = .empty,
+symbols_extra: std.ArrayListUnmanaged(u32) = .empty,
+globals: std.ArrayListUnmanaged(MachO.SymbolResolver.Index) = .empty,
+
+objc_methnames: std.ArrayListUnmanaged(u8) = .empty,
 objc_selrefs: [@sizeOf(u64)]u8 = [_]u8{0} ** @sizeOf(u64),
 
-force_undefined: std.ArrayListUnmanaged(Symbol.Index) = .{},
+force_undefined: std.ArrayListUnmanaged(Symbol.Index) = .empty,
 entry_index: ?Symbol.Index = null,
 dyld_stub_binder_index: ?Symbol.Index = null,
 dyld_private_index: ?Symbol.Index = null,
 objc_msg_send_index: ?Symbol.Index = null,
 mh_execute_header_index: ?Symbol.Index = null,
 mh_dylib_header_index: ?Symbol.Index = null,
 dso_handle_index: ?Symbol.Index = null,
-boundary_symbols: std.ArrayListUnmanaged(Symbol.Index) = .{},
+boundary_symbols: std.ArrayListUnmanaged(Symbol.Index) = .empty,
 
-output_symtab_ctx: MachO.SymtabCtx = .{},
+output_symtab_ctx: MachO.SymtabCtx = .init,
 
 pub fn deinit(self: *InternalObject, allocator: Allocator) void {
     for (self.sections.items(.relocs)) |*relocs| {

src/MachO.zig

@@ -3,9 +3,9 @@ file: fs.File,
 thread_pool: *ThreadPool,
 options: Options,
 
-warnings: std.ArrayListUnmanaged(ErrorMsg) = .{},
+warnings: std.ArrayListUnmanaged(ErrorMsg) = .empty,
 warnings_mutex: std.Thread.Mutex = .{},
-errors: std.ArrayListUnmanaged(ErrorMsg) = .{},
+errors: std.ArrayListUnmanaged(ErrorMsg) = .empty,
 errors_mutex: std.Thread.Mutex = .{},
 
 dyld_info_cmd: macho.dyld_info_command = .{},
@@ -3235,16 +3235,29 @@ const Section = struct {
 };
 
 pub const SymtabCtx = struct {
-    ilocal: u32 = 0,
-    istab: u32 = 0,
-    iexport: u32 = 0,
-    iimport: u32 = 0,
-    nlocals: u32 = 0,
-    nstabs: u32 = 0,
-    nexports: u32 = 0,
-    nimports: u32 = 0,
-    stroff: u32 = 0,
-    strsize: u32 = 0,
+    ilocal: u32,
+    istab: u32,
+    iexport: u32,
+    iimport: u32,
+    nlocals: u32,
+    nstabs: u32,
+    nexports: u32,
+    nimports: u32,
+    stroff: u32,
+    strsize: u32,
+
+    pub const init: SymtabCtx = .{
+        .ilocal = 0,
+        .istab = 0,
+        .iexport = 0,
+        .iimport = 0,
+        .nlocals = 0,
+        .nstabs = 0,
+        .nexports = 0,
+        .nimports = 0,
+        .stroff = 0,
+        .strsize = 0,
+    };
 };
 
 pub const null_sym = macho.nlist_64{
@@ -3365,8 +3378,13 @@ pub const UndefRefs = union(enum) {
 };
 
 pub const String = struct {
-    pos: u32 = 0,
-    len: u32 = 0,
+    pos: u32,
+    len: u32,
+
+    pub const init: String = .{
+        .pos = 0,
+        .len = 0,
+    };
 };
 
 pub const ErrorMsg = struct {

src/Object.zig

@@ -7,34 +7,34 @@ index: File.Index,
 ar_name: ?[]const u8 = null,
 
 header: ?macho.mach_header_64 = null,
-sections: std.MultiArrayList(Section) = .{},
-symtab: std.MultiArrayList(Nlist) = .{},
-strtab: std.ArrayListUnmanaged(u8) = .{},
+sections: std.MultiArrayList(Section) = .empty,
+symtab: std.MultiArrayList(Nlist) = .empty,
+strtab: std.ArrayListUnmanaged(u8) = .empty,
 
-symbols: std.ArrayListUnmanaged(Symbol) = .{},
-symbols_extra: std.ArrayListUnmanaged(u32) = .{},
-globals: std.ArrayListUnmanaged(MachO.SymbolResolver.Index) = .{},
-atoms: std.ArrayListUnmanaged(Atom) = .{},
-atoms_indexes: std.ArrayListUnmanaged(Atom.Index) = .{},
-atoms_extra: std.ArrayListUnmanaged(u32) = .{},
+symbols: std.ArrayListUnmanaged(Symbol) = .empty,
+symbols_extra: std.ArrayListUnmanaged(u32) = .empty,
+globals: std.ArrayListUnmanaged(MachO.SymbolResolver.Index) = .empty,
+atoms: std.ArrayListUnmanaged(Atom) = .empty,
+atoms_indexes: std.ArrayListUnmanaged(Atom.Index) = .empty,
+atoms_extra: std.ArrayListUnmanaged(u32) = .empty,
 
 compile_unit: ?CompileUnit = null,
-stab_files: std.ArrayListUnmanaged(StabFile) = .{},
+stab_files: std.ArrayListUnmanaged(StabFile) = .empty,
 
 eh_frame_sect_index: ?u8 = null,
 compact_unwind_sect_index: ?u8 = null,
-cies: std.ArrayListUnmanaged(Cie) = .{},
-fdes: std.ArrayListUnmanaged(Fde) = .{},
-eh_frame_data: std.ArrayListUnmanaged(u8) = .{},
-unwind_records: std.ArrayListUnmanaged(UnwindInfo.Record) = .{},
-unwind_records_indexes: std.ArrayListUnmanaged(UnwindInfo.Record.Index) = .{},
-data_in_code: std.ArrayListUnmanaged(macho.data_in_code_entry) = .{},
+cies: std.ArrayListUnmanaged(Cie) = .empty,
+fdes: std.ArrayListUnmanaged(Fde) = .empty,
+eh_frame_data: std.ArrayListUnmanaged(u8) = .empty,
+unwind_records: std.ArrayListUnmanaged(UnwindInfo.Record) = .empty,
+unwind_records_indexes: std.ArrayListUnmanaged(UnwindInfo.Record.Index) = .empty,
+data_in_code: std.ArrayListUnmanaged(macho.data_in_code_entry) = .empty,
 
 alive: bool = true,
 hidden: bool = false,
 
 compact_unwind_ctx: CompactUnwindCtx = .{},
-output_symtab_ctx: MachO.SymtabCtx = .{},
+output_symtab_ctx: MachO.SymtabCtx = .init,
 
 pub fn deinit(self: *Object, allocator: Allocator) void {
     allocator.free(self.path);
@@ -1455,7 +1455,7 @@ fn findCompileUnit(self: *Object, gpa: Allocator, dwarf: Dwarf, macho_file: *Mac
         break :str_offsets_base try info_reader.readOffset(cuh.format);
     } else null;
 
-    var cu: CompileUnit = .{ .comp_dir = .{}, .tu_name = .{} };
+    var cu: CompileUnit = .{ .comp_dir = .init, .tu_name = .init };
     for (&[_]struct { Pos, *MachO.String }{
         .{ saved.comp_dir.?, &cu.comp_dir },
         .{ saved.tu_name.?, &cu.tu_name },

src/Symbol.zig

@@ -4,7 +4,7 @@
 value: u64 = 0,
 
 /// Offset into the linker's intern table.
-name: MachO.String = .{},
+name: MachO.String = .init,
 
 /// File where this symbol is defined.
 file: File.OptionalIndex = .none,

src/Thunk.zig

@@ -1,6 +1,6 @@
 value: u64 = 0,
 out_n_sect: u8 = 0,
-symbols: std.AutoArrayHashMapUnmanaged(Symbol.UnwrappedRef, void) = .{},
+symbols: std.AutoArrayHashMapUnmanaged(Symbol.UnwrappedRef, void) = .empty,
 
 pub fn deinit(thunk: *Thunk, allocator: Allocator) void {
     thunk.symbols.deinit(allocator);

src/UnwindInfo.zig

@@ -1,6 +1,6 @@
 /// List of all unwind records gathered from all objects and sorted
 /// by allocated relative function address within the section.
-records: std.ArrayListUnmanaged(Record.Ref) = .{},
+records: std.ArrayListUnmanaged(Record.Ref) = .empty,
 
 /// List of all personalities referenced by either unwind info entries
 /// or __eh_frame entries.
@@ -12,11 +12,11 @@ common_encodings: [max_common_encodings]Encoding = undefined,
 common_encodings_count: u7 = 0,
 
 /// List of record indexes containing an LSDA pointer.
-lsdas: std.ArrayListUnmanaged(u32) = .{},
-lsdas_lookup: std.ArrayListUnmanaged(u32) = .{},
+lsdas: std.ArrayListUnmanaged(u32) = .empty,
+lsdas_lookup: std.ArrayListUnmanaged(u32) = .empty,
 
 /// List of second level pages.
-pages: std.ArrayListUnmanaged(Page) = .{},
+pages: std.ArrayListUnmanaged(Page) = .empty,
 
 pub fn deinit(info: *UnwindInfo, allocator: Allocator) void {
     info.records.deinit(allocator);